test: amplify and optimize doctool/test-make-doc #19581
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesCurrently, the
doctool/test-make-doc.js
has 2 tiny performance nits and 2 logic oversights.Performance nits
Logic oversights.
Makefile
generates docs by getting theconsole.log()
output from thetools/doc/generate.js
and redirecting it to the doc files. Iftools/doc/generate.js
throws, an empty doc file is still created. So we can have a situation when the last.md
source has an error and all the needed files are nevertheless present, just one of them is empty. So we need to check if all the files are not empty.Refactoring strategy
The test is changed considerably, but it may be more strict, full and performant in this form.