v9.11.0 proposal #19799
Merged
v9.11.0 proposal #19799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display the constant name instead of a stream error code in the error message, because the numerical codes give absolutely no clue about what happened when an error is emitted. Backport-PR-URL: #19579 PR-URL: #18966 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
If getTTYfd returns 0, and stdin is not writable (like on Windows), trying to create WriteStream will fail. This commit fixes that by skipping fd 0. PR-URL: #18478 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Correctly check for the presence of the inspector module before adding it to the builtin libs list. PR-URL: #19505 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #19076 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #19076 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
... in addition to the event names they currently use. Currently, various internal streams have different events that indicate that the underlying resource has successfully been established. This commit adds ready event for fs and net sockets to standardize on emitting ready for all of these streams. PR-URL: #19408 Fixes: #19304 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #19461 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #18852 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Make this code (a bit more) comprehensible by adding some internals docs. With diagrams and everything! 🎉 PR-URL: #19469 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host>
PR-URL: #19557 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This commit renames a few of the builtin modules init functions to Initialize for consistency. PR-URL: #19550 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Bump the version due to additions to the api. PR-URL: #19497 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
According to NIST SP 800 38D, this is the document the link orginally pointed to. Fixes: #17619 PR-URL: #19593 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
* improve text for easier comprehension * clarify that performance impact is *negative* * remove superfluous "either" (should only be used when there are 2 options anyway) * remove superfluous italics * line wrap at 80 chars PR-URL: #19623 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Whenever we call into an addon, whether it is for a callback, for module init, or for async work-related reasons, we should make sure that * the last error is cleared, * the scopes before the call are the same as after, and * if an exception was thrown and captured inside the module, then it is re-thrown after the call. Therefore we should call into the module in a unified fashion. This change introduces the macro NAPI_CALL_INTO_MODULE() which should be used whenever invoking a callback provided by the module. Fixes: #19437 PR-URL: #19537 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #19641 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #19581 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #19612 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
- node and v8 did not call into std::string previously, so that access was shut off. - this fixes compilation for ICU 58.2 (backlevel) but may be expressed in other versions also. Fixes: #19151 PR-URL: #19624 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
PR-URL: #19647 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chen Gang <gangc.cxy@foxmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: #19608 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #19666 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Use common.mustCall() where appropriate. Remove some logic that is not required when common.mustCall() is used (incrementor/decrementor to make sure everything is called the same number of times). PR-URL: #19625 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Fixed "cleanup" being misused as a verb * "Use of Foo should only be used" construction changed to "Foo should only be used..." * Otherwise-unmentioned "`Persistent`" changed to more understandable "persistent" * remove an instance of unnecessary italics * wrap at 80 characters Change all "initialize a...instance to zeroes" to say "with zeroes" instead. Previously, both formulations appeared. PR-URL: #19742 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Test process.setuid with an object as an argument. An equivalent test exists for process.seteuid. PR-URL: #19703 Fixes: #19591 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add a `make jstest` target that runs tests written in JavaScript (excluding documentation tests which are run in `make test-doc`). PR-URL: #19324 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
This was added in v8 6.2, looks like a safe replacement for our own buffer::kMaxLength. PR-URL: #19738 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* Replace 2 hyphens (--) by spaced m-dashes (—) as per STYLE_GUIDE.md. * Space infix operators. * Unify quotes in inline code spans (use only single quotes). * Unify `* Returns:` (eliminate deviations). * Dedupe spaces. PR-URL: #19743 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Uses fs.access to implement fs.exists functionality. Fixes a issue, when a file exists but user does not have privileges to do stat on the file. Fixes: #17921 Backport-PR-URL: #19654 PR-URL: #18618 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Moves the creation of `process.binding()`, `process._linkedBinding()`
`internalBinding()` and `NativeModule` into a separate file
`lib/internal/bootstrap_loaders.js`, and documents them there.
This file will be compiled and run before `bootstrap_node.js`, which
means we now bootstrap the internal module & binding system before
actually bootstrapping Node.js.
- Rename the special ID that can be used to require `NativeModule`
as `internal/bootstrap_loaders` since it is setup there. Also put
`internalBinding` in the object exported by `NativeModule.require`
instead of putting it inside the `NativeModule.wrapper`
- Use the original `getBinding()` to get the source code of native
modules instead of getting it from `process.binding('native')`
so that users cannot fake native modules by modifying the binding
object.
- Names the bootstrapping functions so their names show up
in the stack trace.
Backport-PR-URL: #19374
PR-URL: #19112
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Create `lib/internal/bootstrap/` and put bootstrappers there:
Before:
```
lib/internal
├── ...
├── bootstrap_loaders.js
└── bootstrap_node.js
```
After:
```
lib/internal
├── ...
└── bootstrap
├── loaders.js
└── node.js
```
Backport-PR-URL: #19374
PR-URL: #19177
Refs: #19112
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Otherwise the debug log output might be mixed up with the expected errors and the assertion matching the error message would fail. Backport-PR-URL: #19374 PR-URL: #19177 Refs: #19112 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Create `lib/internal/modules` and restructure the module loaders to make the purpose of those files clearer. Also make it clear in the code that the object exported by `lib/internal/modules/cjs/loader.js` is `CJSModule` instead of the ambiguous `Module`. Before: ``` lib ├── ... ├── internal │ ├── loaders │ │ ├── CreateDynamicModule.js │ │ ├── DefaultResolve.js │ │ ├── Loader.js │ │ ├── ModuleJob.js │ │ ├── ModuleMap.js │ │ ├── ModuleWrap.js │ │ └── Translators.js │ └── module.js └── module.js ``` After: ``` lib ├── ... ├── internal │ ├── ... │ └── modules │ ├── cjs │ │ ├── helpers.js │ │ └── loader.js │ └── esm │ ├── CreateDynamicModule.js │ ├── DefaultResolve.js │ ├── Loader.js │ ├── ModuleJob.js │ ├── ModuleMap.js │ └── Translators.js └── module.js # deleted in this commit to work with git file mode ``` Backport-PR-URL: #19374 PR-URL: #19177 Refs: #19112 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
The previous commit deleted lib/module.js so that git recognize the file move `lib/module.js` -> `lib/internal/modules/cjs/loader.js`. This commit add the redirection back. Backport-PR-URL: #19374 PR-URL: #19177 Refs: #19112 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError Backport-PR-URL: #19229 PR-URL: #19061 Fixes: #18855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Notable changes:
* deps:
- Updated ICU to 61.1 (Steven R. Loomis)
[#19621](#19621)
Includes CLDR 33 (many new languages and data improvements).
* fs:
- Emit 'ready' event for `ReadStream` and `WriteStream` (Sameer
Srivastava) [#19408](#19408)
* n-api:
- Bump version of n-api supported (Michael Dawson)
[#19497](#19497)
* net:
- Emit 'ready' event for `Socket` (Sameer Srivastava)
[#19408](#19408)
* Added new collaborators
- [mafintosh](https://github.com/mafintosh) Mathias Buus
nodejs-github-bot
added
build
|
I will publish this release when tests are green |
targos
referenced
this pull request
Apr 6, 2018
Notable changes:
* deps:
- Updated ICU to 61.1 (Steven R. Loomis)
[#19621](#19621)
Includes CLDR 33 (many new languages and data improvements).
* fs:
- Emit 'ready' event for `ReadStream` and `WriteStream` (Sameer
Srivastava) [#19408](#19408)
* n-api:
- Bump version of n-api supported (Michael Dawson)
[#19497](#19497)
* net:
- Emit 'ready' event for `Socket` (Sameer Srivastava)
[#19408](#19408)
* Added new collaborators
- [mafintosh](https://github.com/mafintosh) Mathias Buus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-04-04, Version 9.11.0 (Current), @MylesBorins prepared by @targos
Notable Changes
Includes CLDR 33 (many new languages and data improvements).
ReadStreamandWriteStream(Sameer Srivastava) #19408Socket(Sameer Srivastava) #19408Commits
0bd78dc391] - buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength (Joyee Cheung) #1973854b84f3c26] - buffer: remove "new" from deprecation message (Rich Trott) #196870127712cf5] - build: introduce make jstest (Joyee Cheung) #1932458f61dbf8e] - deps: ICU 61.1 bump (Steven R. Loomis) #1962197a92c4973] - deps: turn in std::string for ICU (Steven R. Loomis) #19624ae86adc086] - doc: fix various nits (Vse Mozhet Byt) #19743041f6cd9c9] - doc: improve Buffer.allocUnsafeSlow() and related (Rich Trott) #1974242671f24ba] - doc: add mafintosh to collaborators (Mathias Buus) #19773c1b83fcbc2] - doc: update to adding listens on SIGUSR1 (willhayslett) #197091aaad92101] - doc: fix lint nits in COLLABORATOR_GUIDE.md (Vse Mozhet Byt) #197625149e18719] - doc: deprecation clarifications (James M Snell) #19522c5469bb7a8] - doc: remove "if provided" for optional arguments (Rich Trott) #196903a3ae0134d] - doc: do not identify string as "JavaScript string" (Rich Trott) #19689d111037624] - doc: favor utf16le over ucs2 in buffer.md (Rich Trott) #19688bb32bc8686] - doc: fix links in vm.md (Vse Mozhet Byt) #1972144361bd1c8] - doc: fix quotes mistypes in inline code blocks (Сковорода Никита Андреевич) #19713c8fa8f1f9d] - doc: remove ES6/ECMAScript 2015 from buffer.md (Rich Trott) #196859f20534889] - doc: shorten character encoding introduction (Rich Trott) #19648078616109c] - doc: guard against md list parsing edge case (Vse Mozhet Byt) #196472ea7f90728] - doc: fix grammar error in process.md (Kenji Okamoto) #196417555deeb8c] - doc: improve zero-fill-buffers text (Rich Trott) #196235e90fc6a85] - fs: use fs.access in fs.exists (Bartosz Sosnowski) #186188a8b43e1b1] - (SEMVER-MINOR) fs,net: emit 'ready' for fs streams and sockets (Sameer Srivastava) #19408e1f44a6366] - http: fixrequestwhensetHostistrue(XadillaX) #19502dac5f67e64] - http: support server options on createServer (Wes Todd) #194612bdf3ca235] - http2: callback valid check before closing request (Trivikram) #190617b850a7565] - http2: destroy() stream, upon errnoException (Sarat Addepalli) #19389441175c29a] - http2: refer to stream errors by name (Anna Henningsen) #189660bcad33c7a] - inspector: report client-visible host and port (Eugene Ostroukhov) #196648e440115ec] - lib: add back lib/module.js redirection (Joyee Cheung) #1917745c477c2e6] - lib: restructure cjs and esm loaders (Joyee Cheung) #19177152a86c6aa] - lib: make isStackOverflowError() engine-agnostic (Mike Kaufman) #19705889a3b44b3] - lib: fix a typo in lib/timers "read through" (wangzengdi) #19666a45f3f8fd2] - lib: document nextTick queue internals (Anna Henningsen) #19469d3d1ee7279] - lib: add internal check macros (Gus Caplan) #18852e0c7d783e0] - lint: change require-buffer rule message (Gus Caplan) #19701859b719927] - module: skip preserveSymlinks for main (Guy Bedford) #19388a0a58730e0] - n-api: back up env before finalize (Gabriel Schulhof) #19718b0a3a44ff6] - n-api: ensure in-module exceptions are propagated (Gabriel Schulhof) #1953794a10bad3a] - (SEMVER-MINOR) n-api: bump version of n-api supported (Michael Dawson) #19497ee4390a167] - repl: fix tab completion of inspector module (Michaël Zasso) #19505ebdcf91dcc] - src: put bootstrappers in lib/internal/bootstrap/ (Joyee Cheung) #19177ff7a116ba3] - src: move internal loaders out of bootstrap_node.js (Joyee Cheung) #1911275d23ab2a0] - src: fix warnings in aliased_buffer (Kyle Farnung) #1966501e31906e8] - src: general C++ cleanup in node_url.cc (Anna Henningsen) #195986c466811d3] - src: name all builtin init functions Initialize (Daniel Bevenius) #195501a38b9bd0f] - src: remove unused 'ares.h' include from env.h (Anna Henningsen) #19557cae9ff256b] - src: fix upcoming V8 deprecation warnings (Sarat Addepalli) #1949083ebaf08d9] - test: remove NODE_DEBUG in global module loading test (Joyee Cheung) #1917792e9ed09e9] - test: test process.setuid for bad argument types (Divyanshu Singh) #197034df3377856] - test: update test to comply with lint rule (Rich Trott) #19784f379167917] - test: improve assert message (fatahn) #1962946569d644d] - test: remove third argument from call to assert.strictEqual() (Forrest Wolf) #19659e44b7779d6] - test: fix flaky test-cluster-send-handle-twice (Rich Trott) #1970090c85461ff] - test: rename regression tests more expressively (Ujjwal Sharma) #19668ff7f28c4f2] - test: remove 3rd argument from assert.strictEqual (Arian Santrach) #197070b27416516] - test: make test-http-expect-continue more strict (Rich Trott) #1966994b28aaf07] - test: use createReadStream instead of ReadStream (Daniel Bevenius) #196367ae2ca4476] - test: removed default message from assert.strictEqual (jaspal-yupana) #19660a89ba21ab4] - test: refactor test-net-dns-error (Luigi Pinca) #19640677b613d24] - test: fix typo in test-tls-cnnic-whitelist (Daniel Bevenius) #19662806bc0d8f7] - test: fix assert.throws error in test-http-parser (Rich Trott) #196262f09ee78fb] - test: refactor test-http-expect-continue (Rich Trott) #19625278e8af7a6] - test: rename tests with descriptive filenames (Ujjwal Sharma) #196080daa063021] - test: amplify and optimize doctool/test-make-doc (Vse Mozhet Byt) #19581274eff5376] - test: update link according to NIST bibliography (Tobias Nießen) #1959321e69d1222] - test: fix test-tty-get-color-depth (Bartosz Sosnowski) #184784caf536b20] - test: http2 stream.respond() error checks (Trivikram) #18861ca97be52a2] - test: fix wrong error classes passed in as type (Ruben Bridgewater) #1368644b12c158d] - test: fix common.expectsError (Refael Ackermann) #13686cc68bc27f8] - test: add more asserts totest-internal-errors(Refael Ackermann) #136866bc49f03b9] - test: http2 errors on req.close() (Trivikram) #1885453d7fbbbf5] - tools: don’t emit illegal utf-8 from icutrim/iculslocs (Steven R. Loomis) #19756b80d169e7c] - tools: apply editorconfig rules to tools also (Tobias Nießen) #19521239a036317] - tools: remove src dir from JS editorconfig rule (Tobias Nießen) #195217043e95fb7] - tools: dry utility function in tools/doc/json.js (Vse Mozhet Byt) #19692140611b2c6] - tools: fix comment nits in tools/doc/*.js files (Vse Mozhet Byt) #196962c5d53f7cb] - tools: fix nits in tools/doc/type-parser.js (Vse Mozhet Byt) #19612fdc51a1331] - url: remove redundant function (Sergey Golovin) #1907699e3c77808] - url: refactor "escapeParam" function to make it common (Sergey Golovin) #19076