-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: explain edge case when assigning port to url #19645
Changes from 8 commits
d719151
2cc61c1
257eae0
e402ff4
64863ee
aedadce
a55b432
0d39ca6
92919bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -313,8 +313,9 @@ myURL.port = 1234.5678; | |
console.log(myURL.port); | ||
// Prints 1234 | ||
|
||
// Out-of-range numbers are ignored | ||
myURL.port = 1e10; | ||
// Out-of-range numbers, which are not represented in scientific notation, | ||
// will be ignored. | ||
myURL.port = 1e10; // 10000000000, will be range-checked as described below | ||
console.log(myURL.port); | ||
// Prints 1234 | ||
``` | ||
|
@@ -324,9 +325,27 @@ in the range `0` to `65535` (inclusive). Setting the value to the default port | |
of the `URL` objects given `protocol` will result in the `port` value becoming | ||
the empty string (`''`). | ||
|
||
If an invalid string is assigned to the `port` property, but it begins with a | ||
number, the leading number is assigned to `port`. Otherwise, or if the number | ||
lies outside the range denoted above, it is ignored. | ||
Upon assigning a value to the port, the value will first be converted to a | ||
string using `.toString()`. | ||
|
||
If that string is invalid, but it begins with a number, the leading number is | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: First comma should be removed. |
||
assigned to `port`. | ||
Otherwise, or if the number lies outside the range denoted above, | ||
it is ignored. | ||
|
||
Note that numbers which contain a decimal point, | ||
such as floating-point numbers or numbers in scientific notation, | ||
are not an exception to this rule. | ||
Leading numbers up to the decimal point will be set as the URL's port, | ||
assuming they are valid. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: The line breaks in this are rather inconsistent. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed they are. fortunately markdown doesn't care about my linebreaks :) I wanted to keep the width under 80 characters. |
||
|
||
For example: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Remove this line and put a colon instead of a period after |
||
|
||
```js | ||
myURL.port = 4.567e21; | ||
console.log(myURL.port); | ||
// Prints 4 (because it is the leading number in the string '4.567e21') | ||
``` | ||
|
||
#### url.protocol | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: commas should be removed here.