Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tty: named anonymous functions #20396

Closed
wants to merge 1 commit into from
Closed

tty: named anonymous functions #20396

wants to merge 1 commit into from

Conversation

js-kyle
Copy link
Contributor

@js-kyle js-kyle commented Apr 29, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines

Ref: #8913

@nodejs-github-bot nodejs-github-bot added the tty Issues and PRs related to the tty subsystem. label Apr 29, 2018
@apapirovski
Copy link
Member

Hi @js-kyle — thanks for taking this on. Unfortunately the original issue that this likely came from needs to be updated. We're not updating the functions that exist on prototypes since the stack trace name generated by V8 is enough.

@js-kyle js-kyle closed this Apr 29, 2018
@AyushG3112 AyushG3112 mentioned this pull request Apr 29, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@js-kyle @apapirovski @nodejs-github-bot