Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: name anonymous functions #20399

Closed
wants to merge 1 commit into from
Closed

child_process: name anonymous functions #20399

wants to merge 1 commit into from

Conversation

SerayaEryn
Copy link
Contributor

Refs: #8913

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Apr 29, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2018
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/14579/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2018
@AyushG3112
Copy link
Contributor

AyushG3112 commented Apr 29, 2018 •
edited
Loading

@BridgeAR this should probably be closed, according to #20396 (comment) and #8913 (comment)

@BridgeAR
Copy link
Member

@AyushG3112 these are not prototype functions though? I know due to inference most functions will actually already have their names set and this could also be the case here but it should not hurt either.

@Trott
Copy link
Member

Trott commented Apr 29, 2018 •
edited
Loading

-1 to fast-tracking (especially on a weekend). No objection to the change though.

@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2018
trivikr pushed a commit that referenced this pull request May 3, 2018
@SerayaEryn @trivikr
child_process: name anonymous functions
c493b98 
Refs: #8913

PR-URL: #20399
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@trivikr
Copy link
Member

trivikr commented May 3, 2018

Landed in c493b98

Congratulations @SerayaEryn on your first commit in Node.js core! 🎉 🎉 🎉

@trivikr trivikr closed this May 3, 2018
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@SerayaEryn @MylesBorins
child_process: name anonymous functions
147ced4 
Refs: #8913

PR-URL: #20399
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@SerayaEryn @MylesBorins
child_process: name anonymous functions
b5931e1 
Refs: #8913

PR-URL: #20399
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SerayaEryn @BridgeAR @AyushG3112 @Trott @trivikr @lpinca @nodejs-github-bot