-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build components of v1.x #2101
Conversation
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: nodejs#1955 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
Since we will run linting before compiling or testing there's no need to run it as part of the ci testing. PR-URL: nodejs#1965 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Revewied-By: Evan Lucas <evanlucas@me.com>
PR-URL: nodejs#2004 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PR-URL: nodejs/node-v0.x-archive#20109
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: nodejs#1938 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
On upgrading openssl, all symlinks in pulic header files are replaced with nested include files. The issue was raised that installing them leads to lost its references to real header files. To avoid this, all public header files are copied into the `deps/openssl/openssl/include/openssl/` directory. As a result, we have duplicated header files under `deps/openssl/openssl/` but copied files are refereed in build as specified to include path in openssl.gyp. Fixes: nodejs#1975 PR-URL: nodejs#2016 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
to replace the full src download by node-gyp, using the proper format instead of the full source format PR-URL: nodejs#1975 Reviewed-By: William Blankenship <william.jblankenship@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Rubber-stamp LGTM. |
Releases working, here's an RC: https://iojs.org/download/rc/v1.8.3-rc1/ built @ https://jenkins-iojs.nodesource.com/job/iojs+release/32/ |
The smalloc deprecation commits would be good to back-port but should also pull in the commits around the NODE_DEPRECATED macro. Other candidates:
|
LGTM, let's discuss other possible commits in another pr / issue, or maybe #1736 |
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: #1955 PORT-PR-URL: #2101 PORT-FROM: 1ec53c0 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PORT-PR-URL: #2101 PORT-FROM: c0c0d73 PR-URL: nodejs/node-v0.x-archive#20109
On upgrading openssl, all symlinks in pulic header files are replaced with nested include files. The issue was raised that installing them leads to lost its references to real header files. To avoid this, all public header files are copied into the `deps/openssl/openssl/include/openssl/` directory. As a result, we have duplicated header files under `deps/openssl/openssl/` but copied files are refereed in build as specified to include path in openssl.gyp. Fixes: #1975 PR-URL: #2016 PORT-PR-URL: #2101 PORT-FROM: 1f371e3 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Landed in a971255...d8f260d with port metadata, cheers! |
This gets v1.x working on the current Jenkins setup for tests: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/90/ and it should also be ready for releases.
Also, OpenSSL is upgraded on this branch, I remember @shigeki did that when he did master.
https://gist.github.com/rvagg/ad60803bc1885742780b I think has the commits currently not in v1.x that are in master if anyone would like to browse them and contribute to the @nodejs/lts discussion (not that 1.8.x is LTS, but it's a good proving ground) on the threshold for backports. I haven't looked in detail but I think the only things standing out at me are @indutny's fixes for stream_wrap etc.