Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor some code around crypto::NodeBIO #21984

Closed
wants to merge 4 commits into from
Closed

src: refactor some code around crypto::NodeBIO #21984

wants to merge 4 commits into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/358/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 26, 2018
@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/16062/

@apapirovski apapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 29, 2018
@addaleax
Copy link
Member Author

addaleax commented Aug 1, 2018 •
edited
Loading

New CI: https://ci.nodejs.org/job/node-test-pull-request/16125/

(Edit: Windows is, once again, the final boss here.)

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2018
@addaleax addaleax force-pushed the node-bio-refactor branch from 4c70d68 to c134e75 Compare August 1, 2018 18:23
@addaleax
Copy link
Member Author

addaleax commented Aug 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16289/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2018
jasnell pushed a commit that referenced this pull request Aug 12, 2018
@addaleax @jasnell
src: use smart pointers for NodeBIO
987dc07 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Aug 12, 2018
@addaleax @jasnell
src: avoid possible race during NodeBIO initialization
40ae307 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Aug 12, 2018
@addaleax @jasnell
src: remove unnecessary writes in tls_wrap.cc
e4c4745 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 12, 2018

Landed in 987dc07, 40ae307, and e4c4745

@jasnell jasnell closed this Aug 12, 2018
rvagg pushed a commit that referenced this pull request Aug 13, 2018
@addaleax @rvagg
src: use smart pointers for NodeBIO
4590a1c 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 13, 2018
@addaleax @rvagg
src: avoid possible race during NodeBIO initialization
28d4d5f 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 13, 2018
@addaleax @rvagg
src: remove unnecessary writes in tls_wrap.cc
b7c872a 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @apapirovski @jasnell