Release proposal: v10.9.0 #22295
Merged
Release proposal: v10.9.0 #22295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #21929 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure). PR-URL: #21860 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This is the first step in a long process of deprecating `process.binding()` and replacing it with `internalBinding()`. Eventually, once we have replaced internal uses of `process.binding()` with `internalBinding()`, we can escalate to a runtime deprecation and eventual end-of-life. PR-URL: #22004 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
A forward declaration suffices and means that the tracing agent header and its dependencies don’t need to be included in nearly every Node.js file. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Avoid unnecessary copies/extra operations & align with our style guide, and add protection against throwing getters. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Avoid unnecessary operations, add a bit of documentation, and turn the `ClientHandle` smart pointer alias into a real class. This should allow de-coupling the unnecessary combination of a single specific `file_writer` from `Agent`. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
The agent code is supposed to manage multiple writers/clients. Adding the default writer into the mix breaks that encapsulation. Instead, manage default options through a separate "virtual" default client handle, and keep the file writer management all to the actual users. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Otherwise this would have crashed the process. In particular, checking the return value of an libuv call against `-1` was invalid to begin with, as libuv uses it to propagate the error code. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Clean up resources when tearing down the tracing agent. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Run the initialization for the file trace writer’s `uv_async_t`s on the same thread as `uv_run()` for their loop to avoid race conditions. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Close existing file descriptors before overriding the field with new ones. Also, use `nullptr` as the loop for these synchronous operations, since they do not run on the same thread as the `uv_run()` call for the previously used loop. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Concurrent writes to the same fd are generally not ideal, since it’s not generally guaranteed that data from those writes will end up on disk in the right order. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: #22062 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
There’s no reason to have a separate addon just for testing GC anymore. PR-URL: #22001 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Grammatical error corrected. PR-URL: #22067 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
The timers directory test, utilizing FakeTime, has not worked in quite a while and is not truly testing Node.js behaviour. If a similar test is necessary it would be better suited to libuv on which Node.js relies for timers functionality. PR-URL: #20894 Fixes: #10154 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Backport-PR-URL: #22039 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
- Updates `test/README.md` with new suites - Fixes some outdated `IGNORED_SUITES` listings - Allows for `test/known_issues` suite to be run by default PR-URL: #21910 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
As noted by @richardlau, `Makefile` and `vcbuild.bat` no longer need to be updated since they run the `default` suite. PR-URL: #22009 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Add missing link at the top. PR-URL: #22072 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Use `setImmediate()` instead of `setTimeout()` to improve robustness of test-http2-session-timeout. Fixes: #20628 PR-URL: #22026 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The existing implementation created a state that if the assert failed we got an error message without the values of hadError. Removed the default error message and added a comment explaining the assert. PR-URL: #22069 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #22047 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #21792 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
On inspector side inside V8 we assume that this method should return number of ms since epoch. PR-URL: #21917 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
dmn 1.0.11 is available. Update update-eslint.sh to use it. Update update-babel-eslint.sh to use it too via npx. Add removeNPMAbsolutePaths to the latter while we're at it. PR-URL: #22035 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
[assert.js](https://github.com/nodejs/node/blob/master/lib/assert.js) uses `stackStartFn` everywhere instead of `stackStartFunction`. This also increases consistency with `stackStartFn` in the `AssertionError` options. PR-URL: #22077 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This reduces the runtime and makes sure the strict and loose options can be tested individually. Besides that a couple of redundant cases were removed. PR-URL: #22211 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The timeout event cannot be precisely timed and the actual timeout may be longer in some situations. Here we move this test into the sequential folder to make it happens less likely. PR-URL: #22083 Fixes: #22041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com>
PR-URL: #22253 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #22301 Refs: nodejs/reliability#12 Refs: #16354 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
PR-URL: #22307 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Actually we don't refer the `error` directly in `filterInternalStackFrames`, so just remove it anyway. PR-URL: #22267 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #22242 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
PR-URL: #22262 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
ICU has been on 6X for a while but example file name in Intl docs still refers to it as 5X. It might be a small thing but I think it's good to update this to avoid confusion. PR-URL: #22313 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #22324 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Simplify format explanation for urlObject.auth. PR-URL: #22324 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
The "at sign" is properly the "commercial at" but let's just avoid the whole naming issue by putting the symbol right in the sentence. PR-URL: #22324 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
It's an octothorp, but no one knows what that is either so let's just show the character in the sentence and be done with it. PR-URL: #22326 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Remove "consists of" in favor of "is". Use "fragment identifier" instead of "fragment" and remove quotes. PR-URL: #22326 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
CVE-2018-12115 Discovered by ChALkeR - Сковорода Никита Андреевич Fix by Anna Henningsen Writing to the second-to-last byte with UCS-2 encoding will cause a -1 length to be send to String::Write(), writing all of the provided Buffer from that point and beyond. Fixes: nodejs-private/security#203 PR-URL: nodejs-private/node-private#138
CVE-2018-7166 Discovered by ChALkeR - Сковорода Никита Андреевич Prevent Buffer.alloc(size, fill, number) from returning uninitialized memory. Fixes: nodejs-private/security#202 PR-URL: nodejs-private/node-private#137 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Notable changes:
* buffer:
* Fix out-of-bounds (OOB) write in `Buffer.write()` for UCS-2 encoding
(CVE-2018-12115)
* Fix unintentional exposure of uninitialized memory in `Buffer.alloc()`
(CVE-2018-7166)
* deps:
* Upgrade to OpenSSL 1.1.0i, fixing:
- Client DoS due to large DH parameter (CVE-2018-0732)
- ECDSA key extraction via local side-channel (CVE not assigned)
* Upgrade V8 from 6.7 to 6.8 (Michaël Zasso) #21079
- Memory reduction and performance improvements, details at:
https://v8project.blogspot.com/2018/06/v8-release-68.html
* http: `http.get()` and `http.request()` (and `https` variants) can now accept
three arguments to allow for a `URL` _and_ an `options` object
(Sam Ruby) #21616
* Added new collaborators
* Sam Ruby (https://github.com/rubys)
* George Adams (https://github.com/gdams)
Hmm... that is something that definitely needs to be explained in the release notes. Specifically, what does it mean "landed in a semver-patch way"? |
|
Right OK, so I'm not going to clarify this in the release announcement because I'm manually stripping out "SEMVER-MAJOR" but here's the summary for the record:
So here's an interesting topic to mull on next time you're doing a release with ? |
rvagg
force-pushed
the
v10.9.0-proposal
branch
from
604bac1 to
03b8258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also needs some security-related commits, for OpenSSL 1.1.0i when it comes out on the 14th, and some internal fixes that are currently embargoed. See https://nodejs.org/en/blog/vulnerability/august-2018-security-releases/ for details.
There are some
semver-majorPRs referenced here but my understanding is that they've been landed in asemver-patchway. @targos could you give me a 👍 on your work merging in V8 6.8 / #21079 and cherry-picking the non-semver-major parts of #20894 please?Does anything else need to be said about V8 6.8?
Notable Changes
fs.mkdir()recursive option, similar to the mkdirp npm package ormkdir -pon the command line (Benjamin Coe) #21875http.get()andhttp.request()(andhttpsvariants) can now accept three arguments to allow for aURLand anoptionsobject (Sam Ruby) #21616Commits
82830a809b] - assert: fix loose assert with map and set (Ruben Bridgewater) #2214500f95039be] - benchmark: improve assert benchmarks (Ruben Bridgewater) #222116622ac798d] - buffer: use FastBuffer when fill is set to 0 (Сковорода Никита Андреевич) #2198901147b4637] - build: make --shared-[...]-path work on Windows (Jeremy Apthorp) #2153008c3f09f30] - build: add CONFIG_FLAGS to with-code-cache target (Daniel Bevenius) #222077135822386] - build: make tools/doc/node_modules non-phony (Daniel Bevenius) #22189d338d412cd] - build: add crypto check to build targets (Daniel Bevenius) #22148d12c9f5af1] - build: extract common parts from addon .buildstamp (Daniel Bevenius) #22171edaafcc3e2] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #2107958580e9ec2] - (SEMVER-MINOR) crypto: add better scrypt option aliases (Anna Henningsen) #215259327a58984] - crypto: remove unused SSLWrap handle methods (Jon Moss) #22216bef02abb7d] - crypto: simplify state failure handling (Tobias Nießen) #221313839ff0b7a] - crypto: simplify Hmac::HmacUpdate (Tobias Nießen) #22132d005ae0628] - (SEMVER-MINOR) crypto: add better scrypt option aliases (Anna Henningsen) #215254dfafac497] - deps: backport c608122b from upstream (Ruben Bridgewater) #222101ce38878ce] - deps: update archs files for OpenSSL-1.1.0i (Shigeki Ohtsu) #2231809a7f1efc6] - (SEMVER-MAJOR) deps: add s390 asm rules for OpenSSL-1.1.0 (Shigeki Ohtsu) #19794337f6b3573] - deps: upgrade openssl sources to 1.1.0i (Shigeki Ohtsu) #22318e1dcb795dd] - deps: cherry-pick 09bca09 from upstream V8 (Matheus Marchini) #220684e6be4c659] - (SEMVER-MINOR) deps: remove thread_local to fix V8 compilation (Peter Marshall) #21668ce5cacda6e] - deps: refactor v8.gyp (Michaël Zasso) #220173cf809d4d6] - (SEMVER-MINOR) deps: patch the V8 API to be backwards compatible with 6.7 (Peter Marshall) #2166848ab7dcc55] - deps: cherry-pick 804a693 from upstream V8 (Matheus Marchini) #21855eb9850a64f] - deps: V8: Backport of 0dd3390 from upstream (James M Snell) #21899ada715f9db] - deps: cherry-pick 907d7bc from upstream V8 (Michaël Zasso) #218387299421bbc] - deps: cherry-pick 2075910 from upstream V8 (Michaël Zasso) #21838c712e8c56c] - deps: cherry-pick 555c811 from upstream V8 (Anna Henningsen) #21741a9ec8884ff] - deps: cherry-pick 477df06 from upstream v8 (Gus Caplan) #216443afffebb5b] - deps: cherry-pick 70c4340 from upstream V8 (Matheus Marchini) #21126ffa835e3bb] - deps: cherry-pick acc336c from upstream V8 (Matheus Marchini) #211265b6c40116a] - deps: cherry-pick b20faff from upstream V8 (Matheus Marchini) #21126d9f566a7be] - (SEMVER-MAJOR) deps: cherry-pick aa6ce3e from upstream V8 (Michaël Zasso) #21079d7af2fa9a7] - deps: cherry-pick 5dd3395 from upstream V8 (Matheus Marchini) #2138664e4e4eed9] - (SEMVER-MAJOR) deps: update v8.gyp and run Torque (Michaël Zasso) #210792f6557390f] - (SEMVER-MAJOR) deps: update V8 to 6.8.275.24 (Michaël Zasso) #21079b7b4aa057d] - doc: simplify urlObject.hash text (Rich Trott) #223269508911d1c] - doc: simplify urlObject.hash description (Rich Trott) #22326ec6a8611b5] - doc: simplify format description of urlObject.auth (Rich Trott) #223243be55faaf5] - doc: remove redundant explanation of format (Rich Trott) #2232467e268ff20] - doc: use italics for words-as-words (Rich Trott) #22324127d2ca537] - doc: bump ICU version to avoid confusion (Csaba Palfi) #223138f79a90db4] - doc: document 'inherit' option for stdio (non-shorthand) (James Bromwell) #223099a31fdc903] - doc: clarify http2 docs around class exports (James M Snell) #2224705544bad21] - doc: add multiple issue templates for GitHub (Tobias Nießen) #2221579b7a58671] - doc: declare all parameter types (Sam Ruby) #21782bc6905bff6] - doc: add missing option for child_process.spawnSync() (James Bromwell) #22231ab1e5d1152] - doc: list encodings supported by buffer.transcode (James M Snell) #222633814e467d3] - doc: discuss special protocol handling (James M Snell) #2226199793b8806] - doc: replace _WG_ with _team_ (Rich Trott) #22183e313961e17] - doc: add subprocess.ref() and subprocess.unref() (Thomas Hunter II) #222205ba56e5695] - doc: add gdams to collaborators (George Adams) #22236e80c646702] - doc: specifyoptionsparameter type in zlib.md (Vse Mozhet Byt) #2192040af9767a2] - doc: declare all parameter types (Sam Ruby) #2178238dd407c83] - doc: remove unused error codes from errors.md (Сковорода Никита Андреевич) #214916c7733f58a] - doc: update recommendations for createCipher (Tobias Nießen) #2208734300aaaa4] - doc: correct crypto.randomFill() and randomFillSync() (Gerhard Stoebich) #2155028870a46ac] - doc: add rubys to collaborators (Sam Ruby) #22109d2ad9a2c13] - doc: fix return type of server.address() (Weijia Wang) #22043168abb5801] - doc: rename stackStartFunction in assert.md (Eugene Y. Q. Shen) #22077d364f9c8e7] - doc: fix changelog for v10.8.0 (Michaël Zasso) #22072abac0c56b8] - doc: mark DEP0004 and DEP0042 as End-of-Life (Jon Moss) #22033c6a56ae23e] - doc: correct grammatical error in BUILDING.md (Brandon Lee) #2206729bc55320c] - doc: fixup process.binding deprecation code (James M Snell) #22062ec9d529a32] - doc: documentation deprecation of process.binding (James M Snell) #22004fdeace6a02] - (SEMVER-MINOR) fs: implement mkdir recursive (mkdirp) (Benjamin Coe) #2187537369eba38] - (SEMVER-MINOR) http: allow url and options to be passed to http*.request and http*.get (Sam Ruby) #216161ca46ab6f4] - http,tls: name anonymous callbacks (Marco Levrero) #21412535e0e5be1] - http2: correcting the heading format (Anto Aravinth) #22262a562729e55] - http2: explicitly disallow nested push streams (James M Snell) #2224583373e2f7f] - http2: avoid race condition in OnHeaderCallback (James M Snell) #22256999f55a573] - http2: removestreamErrorfrom docs (James M Snell) #222462bf9a4a09e] - https: allow url and options to be passed to https.request (Sam Ruby) #22003b97c73fd53] - inspector: tie objects lifetime to the thread they belong to (Eugene Ostroukhov) #2224264c89d2671] - inspector: unmark tests as flaky (Eugene Ostroukhov) #22253c96e552d4f] - inspector: add inspector_protocol as a direct dependency (Andrey Lushnikov) #21975311ec12702] - inspector: fixed V8InspectorClient::currentTimeMS (Aleksey Kozyatinskiy) #2191722b9691772] - lib: remove unused filterInternalStackFrames param (MaleDong) #22267193a0480cd] - lib: extract validateString validator (Jon Moss) #221019e410328bd] - perf_hooks: avoid memory leak on gc observer (James M Snell) #2224176a65921d3] - readline,zlib: named anonymous functions (Anto Aravinth) #21792e4f346892c] - repl: support mult-line string-keyed objects (Sam Ruby) #21805b7c872a58a] - src: remove unnecessary writes in tls_wrap.cc (Anna Henningsen) #2198428d4d5fdb6] - src: avoid possible race during NodeBIO initialization (Anna Henningsen) #219844590a1c3a2] - src: use smart pointers for NodeBIO (Anna Henningsen) #219845b7419bc4c] - src: fix integer overflow in GetNow (Anatoli Papirovski) #22214b3eb10d9bd] - src: add READONLY_STRING_PROPERTY and simplify config (Jon Moss) #22222d13d60da12] - src: fix up doc comment for experimental-worker bool (Anna Henningsen) #2216513e1d63801] - src: remove calls to deprecated v8 functions (NumberValue) (Ujjwal Sharma) #220949d801997c4] - src: remove unused env->vm_parsing_context_symbol (Jon Moss) #220346ca00d7044] - src: remove unused env strings (Jon Moss) #221370ca831a0ed] - src: clean up PackageConfig pseudo-boolean fields (Anna Henningsen) #2198700c33a5131] - src: clean up agent loop when exiting through destructor (Anna Henningsen) #21867ba480d33ce] - src: use only one tracing write fs req at a time (Anna Henningsen) #218676b58746b2e] - src: use unique_ptr for internal JSON trace writer (Anna Henningsen) #21867ce48936077] - src: plug trace file file descriptor leak (Anna Henningsen) #2186789e23021fb] - src: initialize file trace writer on tracing thread (Anna Henningsen) #2186756edd5fc5b] - src: close tracing event loop (Anna Henningsen) #218674c9c1bbc45] - src: fix tracing if cwd or file path is inaccessible (Anna Henningsen) #21867c101b396aa] - src: refactor default trace writer out of agent (Anna Henningsen) #21867daafe6c195] - src: refactor tracing agent code (Anna Henningsen) #218674379140dbf] - src: minor refactor of node_trace_events.cc (Anna Henningsen) #21867cde0e5f396] - src: reduce unnecessary includes (Anna Henningsen) #218671c61205d73] - stream: fix readable behavior for highWaterMark === 0 (Denys Otrishko) #2169065d1e027a3] - test: rename some allegories (Vse Mozhet Byt) #223079feee1f665] - test: call gc() explicitly to avoid OOM (Refael Ackermann) #223013804836534] - test: move test-http-client-timeout-option-with-agent to sequential (Ouyang Yadong) #22083dc57d4e87f] - test: add test-http2-large-file sequential test (James M Snell) #222541ed03b0987] - test: fix error messages for OpenSSL-1.1.0i (Shigeki Ohtsu) #22318afd3d49d98] - test: improve test coverage for comparisons (Ruben Bridgewater) #222120385e09745] - test: remove common.fileExists() (Rich Trott) #221516f28557a17] - test: handle errors correctly in GC http test (Ouyang Yadong) #221853666993e77] - test: remove second arg from assert.ifError() (Musa Hamwala) #221903baeb82f43] - test: move require of https to after crypto check (Daniel Bevenius) #22148fcc150dbc1] - test: move require of http2 to after crypto check (Daniel Bevenius) #2214895b2467d5f] - test: don't mask descriptor.enumerable (Thomas Leah) #221726f47a84656] - test: remove common.fileExists() (Richard Lau) #22200f1b34f99e0] - test: remove unused argument in assertion (yahavfuchs) #221139d85a059b7] - test: check arg type for dnsPromises.resolve (Masashi Hirano) #2200043c5455ac9] - (SEMVER-MAJOR) test: update postmortem metadata test (cjihrig) #210793175391e1d] - (SEMVER-MAJOR) test: fix scriptParsed event expectations (Ingvar Stepanyan) #21079a6b9ee9c89] - test: update certificates and private keys (Fedor Indutny) #22184d38ccaa421] - test: fix n-api addon build warnings (Kyle Farnung) #21808d66e52fb8e] - test: run ESM tests in parallel (Michaël Zasso) #219196cff57e98d] - test: fix incorrect file mode check (Timothy Gu) #22023dafaff3a5e] - test: remove unused config (Benjamin Gruenbaum) #21985a569ae4b44] - test: remove third argument from assert.strictEqual() (Rishabh Singh) #22051a60060b499] - test: remove third argument from call to assert.strictEqual() (Michael Sommer) #22047246a94f301] - test: see value of "hadError" in tls test (Oryan Moshe) #22069a40ee213b3] - test: improve reliability in http2-session-timeout (Rich Trott) #22026e2d97eeb65] - test: remove outdated documentation (Jon Moss) #2200994746d6a47] - (SEMVER-MAJOR) test: remove outdated, non-functioning test (Anatoli Papirovski) #208940beffc0f3b] - test: remove test/gc, integrate into parallel (Anna Henningsen) #22001c2372eac16] - test: add tracing crash regression test (Eugene Ostroukhov) #218677e23080d45] - test: pass through stderr in benchmark tests (Anna Henningsen) #2186052020dc09a] - test: refactor test-http2-compat-serverresponse-finished.js (Anto Aravinth) #21929fbc45d408d] - test,doc: fix async-hooks coverage doc for md lint (Rod Vagg) #22296339f6f62a9] - test,doc: adjust markdown table for linting (Rich Trott) #22221ffb01dd151] - test,doc: adjust async-hooks coverage doc for lint (Rich Trott) #22221a0b3c4ac35] - test,doc: wrap common module md doc at 80 chars (Rich Trott) #222212bab323a52] - test,doc: fix lint error in test fixtures (Rich Trott) #222214ad4e377bc] - tls: change var to const (Eugen Cazacu) #222197cb05cf2a0] - tls: remove SLAB_BUFFER_SIZE (Anatoli Papirovski) #21199b1a9cf756b] - tls: preallocate SSL cipher array (Tobias Nießen) #22136df7d33e398] - tools: fix header escaping regression (Sam Ruby) #22084f0c71d7361] - tools: add no-misleading-character-class ESLint rule (Vse Mozhet Byt) #22278f68b165532] - tools: do not autolink section to itself (Vse Mozhet Byt) #22138e152cf7209] - tools: update ESLint to 5.3.0 (Rich Trott) #2213444edfa436c] - tools: convert addon-verify to remark (Sam Ruby) #21978c85d00b786] - tools: produce JSON documentation using unified/remark/rehype (Sam Ruby) #21697f0c871b0c7] - tools: addmake format-cppto run clang-format on C++ diffs (Joyee Cheung) #219975a4abbadfe] - tools: update to using dmn 1.0.11 (Rich Trott) #220357a7c194f4e] - tools: fix docs and run known_issues by default (Jon Moss) #219107933310a4b] - tools,build: apply markdown linting to test dir (Rich Trott) #22221fd318e70b5] - trace_events: add node.promises category, rejection counter (James M Snell) #22124df087cf09e] - util: improve display of iterators and weak entries (Ruben Bridgewater) #2096141b5172e11] - util,assert: fix boxed primitives bug (Ruben Bridgewater) #22243561b1f51df] - worker: fix deadlock when calling terminate from exit handler (Anna Henningsen) #2207300b0a62988] - zlib: remove unused parameters (MaleDong) #22115