Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing argv0 option for child_process.spawnSync #22231

Closed
wants to merge 1 commit into from
Closed

doc: add missing argv0 option for child_process.spawnSync #22231

wants to merge 1 commit into from

Conversation

thw0rted
Copy link
Contributor

The child_process docs include argv0 as an option for spawn but not spawnSync. This is a documentation oversight, because the actual functions share the same options parsing logic.

Checklist

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Aug 10, 2018
@thw0rted thw0rted mentioned this pull request Aug 10, 2018
Merged
9 tasks
Trott
Trott approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @thw0rted. Welcome, and thanks for the pull request. It looks good to me.

It might be out of scope for this change, but I think the options should be alphabetized. Maybe if you're eager to do a second pull request or something.

/ping @nodejs/child_process @nodejs/documentation for reviews

@Trott
Copy link
Member

Trott commented Aug 10, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/494/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 10, 2018
@BridgeAR
Copy link
Member

Having them alphabetically would be nice but in that case the other entry has to be moved as well. This is in sync with the other documentation.

@trivikr
Copy link
Member

trivikr commented Aug 11, 2018

Thank you @thw0rted for your contribution.
Looks like the email used in the commit is not registered with Github. Kindly register it with Github, or set up your user.email as explained here

The author for the last commit can be updated by following these steps

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 12, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 1f32cca
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Aug 12, 2018
@thw0rted @vsemozhetbyt
doc: add missing option for child_process.spawnSync()
1f32cca 
PR-URL: #22231
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Aug 12, 2018
@thw0rted @targos
doc: add missing option for child_process.spawnSync()
bc6905b 
PR-URL: #22231
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Aug 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@thw0rted @Trott @BridgeAR @trivikr @vsemozhetbyt @lpinca @cjihrig @nodejs-github-bot