crypto: remove unused SSLWrap handle methods #22216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One was not used at all, and the other was only used in a test, which I converted to use the more standard `ShutdownWrap` API.
nodejs-github-bot
added
c++
addaleax
approved these changes
Aug 9, 2018
tniessen
approved these changes
Aug 9, 2018
jasnell
approved these changes
Aug 9, 2018
|
@nodejs/security-wg (Unlikely to actually be a security issue, and security and crypto are not the same thing, and all that. But kind of trying to get a feel for PR volume if the "security and crypto changes need to go through Security WG" proposal goes through.) |
cjihrig
approved these changes
Aug 9, 2018
maclover7
added
the
author ready
|
Landed in 640dc7a |
maclover7
added a commit
that referenced
this pull request
Aug 12, 2018
One was not used at all, and the other was only used in a test, which I converted to use the more standard `ShutdownWrap` API. PR-URL: #22216 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 12, 2018
One was not used at all, and the other was only used in a test, which I converted to use the more standard `ShutdownWrap` API. PR-URL: #22216 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One was not used at all, and the other was only used in a test, which I
converted to use the more standard
ShutdownWrapAPI.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes