Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: avoid race condition in OnHeaderCallback #22256

Closed
wants to merge 1 commit into from
Closed

http2: avoid race condition in OnHeaderCallback #22256

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 10, 2018

Rather than abort, close stream when stream does not exist in OnHeaderCallback

Fixes: #21416

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/513/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Aug 10, 2018
@jasnell jasnell requested review from addaleax and mcollina August 10, 2018 22:09
@jasnell
Copy link
Member Author

jasnell commented Aug 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16356/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2018
mcollina
mcollina approved these changes Aug 11, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams
Copy link
Member

gdams commented Aug 13, 2018

landed in: ac92a42

@gdams gdams closed this Aug 13, 2018
gdams pushed a commit that referenced this pull request Aug 13, 2018
@jasnell
http2: avoid race condition in OnHeaderCallback
ac92a42 
Fixes: #21416

PR-URL: #22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Aug 15, 2018
@jasnell @rvagg
http2: avoid race condition in OnHeaderCallback
83373e2 
Fixes: #21416

PR-URL: #22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@rvagg rvagg mentioned this pull request Aug 15, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
@jasnell @kjin
http2: avoid race condition in OnHeaderCallback
947d0c8 
Fixes: nodejs#21416

PR-URL: nodejs#22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@jasnell @kjin
http2: avoid race condition in OnHeaderCallback
ee3e471 
Fixes: nodejs#21416

PR-URL: nodejs#22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@jasnell @BethGriggs
http2: avoid race condition in OnHeaderCallback
5c3edd3 
Fixes: #21416

Backport-PR-URL: #22850
PR-URL: #22256
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@trivikr trivikr trivikr approved these changes

@addaleax addaleax addaleax approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP2 module crashes and sometimes segfaults when running tests against it
6 participants
@jasnell @nodejs-github-bot @gdams @mcollina @addaleax @trivikr