doc: add rubys to collaborators #22109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubys
added
the
notable-change
Trott
reviewed
Aug 3, 2018
README.md
Outdated
| @@ -470,6 +470,8 @@ For more information about the governance of the Node.js project, see | |||
| * [ronkorving](https://github.com/ronkorving) - | |||
| **Ron Korving** <ron@ronkorving.nl> | |||
| * [RReverser](https://github.com/RReverser) - | |||
| **Sam Ruby** <rubys@intertwingly.net> | |||
| * [rubys](https://github.com/rubys) - | |||
Trott
approved these changes
Aug 3, 2018
vsemozhetbyt
approved these changes
Aug 3, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
gireeshpunathil
approved these changes
Aug 3, 2018
vsemozhetbyt
added
fast-track
richardlau
approved these changes
Aug 3, 2018
cjihrig
approved these changes
Aug 3, 2018
bengl
approved these changes
Aug 3, 2018
TimothyGu
approved these changes
Aug 3, 2018
|
Landed in f19fa7c |
rubys
added a commit
that referenced
this pull request
Aug 3, 2018
PR-URL: #22109 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
targos
pushed a commit
that referenced
this pull request
Aug 4, 2018
PR-URL: #22109 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes