doc: improve urlObject.hash documentation #22326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an octothorp, but no one knows what that is either so let's just show the character in the sentence and be done with it.
Remove "consists of" in favor of "is". Use "fragment identifier" instead of "fragment" and remove quotes.
nodejs-github-bot
added
doc
vsemozhetbyt
approved these changes
Aug 14, 2018
vsemozhetbyt
added
the
author ready
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
bengl
approved these changes
Aug 14, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 14, 2018
It's an octothorp, but no one knows what that is either so let's just show the character in the sentence and be done with it. PR-URL: nodejs#22326 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 14, 2018
Remove "consists of" in favor of "is". Use "fragment identifier" instead of "fragment" and remove quotes. PR-URL: nodejs#22326 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
|
Landed in b002f6e...a091fbe |
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
It's an octothorp, but no one knows what that is either so let's just show the character in the sentence and be done with it. PR-URL: #22326 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
Remove "consists of" in favor of "is". Use "fragment identifier" instead of "fragment" and remove quotes. PR-URL: #22326 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nodejs/documentation @nodejs/url
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes