Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test coverage for comparisons #22212

Closed
wants to merge 1 commit into from
Closed

test: improve test coverage for comparisons #22212

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Aug 9, 2018

A few last cases that were not covered so far.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/475/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 9, 2018
mcollina
mcollina approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 9, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Aug 9, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/16304/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2018
@joyeecheung joyeecheung mentioned this pull request Aug 10, 2018
Closed
@BridgeAR BridgeAR force-pushed the improve-assert-coverage branch from f48b36a to df29a1d Compare August 10, 2018 11:45
@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/16337/

@jasnell
Copy link
Member

jasnell commented Aug 12, 2018

Rerun custom-suites CI:https://ci.nodejs.org/job/node-test-commit-custom-suites/628/

jasnell pushed a commit that referenced this pull request Aug 12, 2018
@BridgeAR @jasnell
test: improve test coverage for comparisons
c3bd651 
PR-URL: #22212
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 12, 2018

Landed in c3bd651

@jasnell jasnell closed this Aug 12, 2018
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 13, 2018
@BridgeAR @rvagg
test: improve test coverage for comparisons
afd3d49 
PR-URL: #22212
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
@BridgeAR BridgeAR deleted the improve-assert-coverage branch January 20, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@BridgeAR @nodejs-github-bot @jasnell @apapirovski @mcollina @benjamingr @lpinca @trivikr