Skip to content

Conversation

@maclover7
Copy link
Contributor

As noted by @richardlau, Makefile and vcbuild.bat no longer need to
be updated since they run the default suite.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

As noted by @richardlau, `Makefile` and `vcbuild.bat` no longer need to
be updated since they run the `default` suite.
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 28, 2018
@Trott

This comment has been minimized.

@maclover7
Copy link
Contributor Author

Instead of removing the text, should it be updated to say to consider whether to update the default suite in test.py?

The default suite is "opt out" (tools/test.py lists all directories and then removes all "ignored" ones). When adding a new test directory, tools/test.py should be able to run without any updated configuration

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 29, 2018
@maclover7
Copy link
Contributor Author

Landed in 48e1763

@maclover7 maclover7 closed this Jul 31, 2018
@maclover7 maclover7 deleted the jm-rm-testdoc branch July 31, 2018 03:47
maclover7 added a commit that referenced this pull request Jul 31, 2018
As noted by @richardlau, `Makefile` and `vcbuild.bat` no longer need to
be updated since they run the `default` suite.

PR-URL: #22009
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 31, 2018
@targos
Copy link
Member

targos commented Jul 31, 2018

Depends on #21910 to land on v10.x-staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants