Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: simplify state failure handling #22131

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Aug 4, 2018

It is more intuitive to return true/false than undefined/false. This also simplifies handling in the JS layer and removes two control-flow branches from C++.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

It is more intuitive to return true/false instead of undefined/false
and also simplifies handling in the JS layer.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Aug 4, 2018
@tniessen
Copy link
Member Author

tniessen commented Aug 4, 2018

cc @nodejs/crypto

@Trott
Copy link
Member

Trott commented Aug 5, 2018

@nodejs/security-wg

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 5, 2018
@tniessen
Copy link
Member Author

tniessen commented Aug 5, 2018

Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@trivikr
Copy link
Member

trivikr commented Aug 8, 2018

Landed in 77ac962

@trivikr trivikr closed this Aug 8, 2018
trivikr pushed a commit that referenced this pull request Aug 8, 2018
It is more intuitive to return true/false instead of undefined/false
and also simplifies handling in the JS layer.

PR-URL: #22131
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos pushed a commit that referenced this pull request Aug 11, 2018
It is more intuitive to return true/false instead of undefined/false
and also simplifies handling in the JS layer.

PR-URL: #22131
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants