Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: avoid memory leak on gc observer #22241

Closed
wants to merge 1 commit into from
Closed

perf_hooks: avoid memory leak on gc observer #22241

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 10, 2018

Fixes: #22229

/cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/495/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 10, 2018
@jasnell
Copy link
Member Author

jasnell commented Aug 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16342/

@jasnell
Copy link
Member Author

jasnell commented Aug 11, 2018

Some odd failures in CI, trying again: https://ci.nodejs.org/job/node-test-pull-request/16364/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2018
@trivikr
Copy link
Member

trivikr commented Aug 12, 2018

Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/16381/

@gdams
Copy link
Member

gdams commented Aug 13, 2018

landed in: f6eab1a

@gdams gdams closed this Aug 13, 2018
gdams pushed a commit that referenced this pull request Aug 13, 2018
@jasnell
perf_hooks: avoid memory leak on gc observer
f6eab1a 
Fixes: #22229

PR-URL: #22241
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Aug 15, 2018
@jasnell @rvagg
perf_hooks: avoid memory leak on gc observer
9e41032 
Fixes: #22229

PR-URL: #22241
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@rvagg rvagg mentioned this pull request Aug 15, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hashseed hashseed hashseed approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @trivikr @gdams @addaleax @hashseed @cjihrig