Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "tools,gyp: don't force build actions with multiple outputs" #23257

Closed
wants to merge 1 commit into from
Closed

Revert "tools,gyp: don't force build actions with multiple outputs" #23257

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

This reverts commit 5d8373a.

Fixes: #23255

cc @refack @devsnek @targos

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@thefourtheye build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1122/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Oct 4, 2018
@danbev
Copy link
Contributor

danbev commented Oct 4, 2018

Could this be fast-tracked? If you think so please add a 👍

@thefourtheye
Copy link
Contributor Author

As per @danbev's comment #23255 (comment), make clean fixes this problem.

@thefourtheye thefourtheye deleted the unblock-local-make branch October 4, 2018 08:35
@cjihrig cjihrig mentioned this pull request Oct 4, 2018
Closed
@thefourtheye thefourtheye restored the unblock-local-make branch October 4, 2018 13:39
@thefourtheye
Copy link
Contributor Author

Reopening as per #23255 (comment). Even my rebuild after make clean stopped responding.

@thefourtheye thefourtheye reopened this Oct 4, 2018
@refack
Copy link
Contributor

refack commented Oct 4, 2018

Well, back to the drawing board for me 🤷‍♂️

@refack refack added the regression Issues related to regressions. label Oct 4, 2018
@refack
Copy link
Contributor

refack commented Oct 4, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17630/

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 4, 2018
@addaleax
Copy link
Member

addaleax commented Oct 4, 2018

Landed in 17a0cd2

@addaleax addaleax closed this Oct 4, 2018
addaleax pushed a commit that referenced this pull request Oct 4, 2018
@thefourtheye @addaleax
Revert "tools,gyp: don't force build actions with multiple outputs"
17a0cd2 
This reverts commit 5d8373a.

Fixes: #23255

PR-URL: #23257
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@devsnek
Copy link
Member

devsnek commented Oct 5, 2018

This hasn't fixed the problem for me :(

@danbev
Copy link
Contributor

danbev commented Oct 5, 2018

@devsnek Just wanted to ask if you have done another make clean. I ran into this once more yesterday after updating master (I'm not exactly sure but I think it was after 9800fd7). After doing a make clean I've not seen it again. This might just be a coincidence but my thinking was that perhaps one of the generated makefiles was stale in some way (missing dependency or something like) causing this and was the reason I did a clean again. I'm on mac by the way just incase that might matter.

targos pushed a commit that referenced this pull request Oct 5, 2018
@thefourtheye @targos
Revert "tools,gyp: don't force build actions with multiple outputs"
a656268 
This reverts commit 5d8373a.

Fixes: #23255

PR-URL: #23257
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@refack refack mentioned this pull request Oct 5, 2018
Closed
2 tasks
@targos targos mentioned this pull request Oct 10, 2018
Merged
@beevelop beevelop mentioned this pull request Oct 10, 2018
Closed
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@targos targos mentioned this pull request Oct 17, 2018
Closed
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@thefourtheye @jasnell
Revert "tools,gyp: don't force build actions with multiple outputs"
0e33493 
This reverts commit 5d8373a.

Fixes: #23255

PR-URL: #23257
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Oct 24, 2018
Merged
3 tasks
@refack refack mentioned this pull request Oct 30, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. regression Issues related to regressions. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make with -j hangs
7 participants
@thefourtheye @nodejs-github-bot @danbev @refack @addaleax @devsnek @cjihrig