http2: add RFC 8441 extended connect protocol support #23284

jasnell · 2018-10-05T22:13:52Z

Add RFC 8441 extended connect protocol support to allow use of WebSockets over HTTP/2.

Note: this does not add the websockets support but it does enable the fundamentals that are necessary to enable such.

/cc @nodejs/http2

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Key new feature: RFC 8441 `:protocol` support

nodejs-github-bot · 2018-10-05T22:13:53Z

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1132/pipeline

devsnek

I can't speak speak for the code changes but this feature looks awesome.

jasnell · 2018-10-05T23:32:54Z

Basic proof of concept that it works: https://github.com/jasnell/http2ws/blob/master/http2ws.js

rauchg · 2018-10-05T23:44:26Z

Nice work!

addaleax · 2018-10-05T23:44:56Z

doc/api/http2.md

+client.on('remoteSettings', (settings) => {
+  if (settings.enableConnectProtocol) {
+    const req = client.request({ ':method': 'CONNECT', ':protocol': 'foo' });
+    // ...


Just when it got interesting ;) How does one use this feature? Is the idea that req is a raw Duplex stream now and another protocol can use it as its underlying transport stream?

Effectively yeah... RFC 8441 says that the HTTP/2 Stream is to be used in place of the Socket... so here, the Http2Stream (on both client and server) is the underlying transport... layering FTW!

There are some challenges, however, in that the ws WebSocket implementation has a number of timing and API expectations built in that don't quite match up but, for the most part, it just kinda works.

jasnell · 2018-10-06T19:51:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17666/

jasnell · 2018-10-06T22:19:19Z

Resume: https://ci.nodejs.org/job/node-test-commit/22076/

trivikr · 2018-10-07T08:43:19Z

Resume: https://ci.nodejs.org/job/node-test-commit/22078/ ✔️

trivikr

RSLGTM

Key new feature: RFC 8441 `:protocol` support PR-URL: #23284 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #23284 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

jasnell · 2018-10-08T15:45:36Z

Landed in 8290015 and 0ad8c73

Key new feature: RFC 8441 `:protocol` support PR-URL: #23284 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #23284 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Notable changes: * assert * The diff output is now a tiny bit improved by sorting object properties when inspecting the values that are compared with each other. #22788 * cli * The options parser now normalizes `_` to `-` in all multi-word command-line flags, e.g. `--no_warnings` has the same effect as `--no-warnings`. #23020 * Added bash completion for the `node` binary. To generate a bash completion script, run `node --completion-bash`. The output can be saved to a file which can be sourced to enable completion. #20713 * crypto * Added support for PEM-level encryption. #23151 * Added an API asymmetric key pair generation. The new methods `crypto.generateKeyPair` and `crypto.generateKeyPairSync` can be used to generate public and private key pairs. The API supports RSA, DSA and EC and a variety of key encodings (both PEM and DER). #22660 * fs * Added a `recursive` option to `fs.mkdir` and `fs.mkdirSync`. If this option is set to true, non-existing parent folders will be automatically created. #21875 * http2 * Added a `'ping'` event to `Http2Session` that is emitted whenever a non-ack `PING` is received. #23009 * Added support for the `ORIGIN` frame. #22956 * Updated nghttp2 to 1.34.0. This adds RFC 8441 extended connect protocol support to allow use of WebSockets over HTTP/2. #23284 * module * Added `module.createRequireFromPath(filename)`. This new method can be used to create a custom require function that will resolve modules relative to the filename path. #19360 * process * Added a `'multipleResolves'` process event that is emitted whenever a `Promise` is attempted to be resolved multiple times, e.g. if the `resolve` and `reject` functions are both called in a `Promise` executor. #22218 * url * Added `url.fileURLToPath(url)` and `url.pathToFileURL(path)`. These methods can be used to correctly convert between file: URLs and absolute paths. #22506 * util * Added the `sorted` option to `util.inspect()`. If set to `true`, all properties of an object and Set and Map entries will be sorted in the returned string. If set to a function, it is used as a compare function. #22788 * The `util.instpect.custom` symbol is now defined in the global symbol registry as `Symbol.for('nodejs.util.inspect.custom')`. #20857 * Added support for `BigInt` numbers in `util.format()`. #22097 * V8 API * A number of V8 C++ APIs have been marked as deprecated since they have been removed in the upstream repository. Replacement APIs are added where necessary. #23159 * Windows * The Windows msi installer now provides an option to automatically install the tools required to build native modules. #22645 * Workers * Debugging support for Workers using the DevTools protocol has been implemented. #21364 * The public `inspector` module is now enabled in Workers. #22769 * Added new collaborators: * digitalinfinity - Hitesh Kanwathirtha PR-URL: #23313

Key new feature: RFC 8441 `:protocol` support PR-URL: #23284 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #23284 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Notable changes: * assert * The diff output is now a tiny bit improved by sorting object properties when inspecting the values that are compared with each other. #22788 * cli * The options parser now normalizes `_` to `-` in all multi-word command-line flags, e.g. `--no_warnings` has the same effect as `--no-warnings`. #23020 * Added bash completion for the `node` binary. To generate a bash completion script, run `node --completion-bash`. The output can be saved to a file which can be sourced to enable completion. #20713 * crypto * Added support for PEM-level encryption. #23151 * Added an API asymmetric key pair generation. The new methods `crypto.generateKeyPair` and `crypto.generateKeyPairSync` can be used to generate public and private key pairs. The API supports RSA, DSA and EC and a variety of key encodings (both PEM and DER). #22660 * fs * Added a `recursive` option to `fs.mkdir` and `fs.mkdirSync`. If this option is set to true, non-existing parent folders will be automatically created. #21875 * http2 * Added a `'ping'` event to `Http2Session` that is emitted whenever a non-ack `PING` is received. #23009 * Added support for the `ORIGIN` frame. #22956 * Updated nghttp2 to 1.34.0. This adds RFC 8441 extended connect protocol support to allow use of WebSockets over HTTP/2. #23284 * module * Added `module.createRequireFromPath(filename)`. This new method can be used to create a custom require function that will resolve modules relative to the filename path. #19360 * process * Added a `'multipleResolves'` process event that is emitted whenever a `Promise` is attempted to be resolved multiple times, e.g. if the `resolve` and `reject` functions are both called in a `Promise` executor. #22218 * url * Added `url.fileURLToPath(url)` and `url.pathToFileURL(path)`. These methods can be used to correctly convert between file: URLs and absolute paths. #22506 * util * Added the `sorted` option to `util.inspect()`. If set to `true`, all properties of an object and Set and Map entries will be sorted in the returned string. If set to a function, it is used as a compare function. #22788 * The `util.instpect.custom` symbol is now defined in the global symbol registry as `Symbol.for('nodejs.util.inspect.custom')`. #20857 * Added support for `BigInt` numbers in `util.format()`. #22097 * V8 API * A number of V8 C++ APIs have been marked as deprecated since they have been removed in the upstream repository. Replacement APIs are added where necessary. #23159 * Windows * The Windows msi installer now provides an option to automatically install the tools required to build native modules. #22645 * Workers * Debugging support for Workers using the DevTools protocol has been implemented. #21364 * The public `inspector` module is now enabled in Workers. #22769 * Added new collaborators: * digitalinfinity - Hitesh Kanwathirtha PR-URL: #23313

Key new feature: RFC 8441 `:protocol` support PR-URL: #23284 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

jasnell added 2 commits October 5, 2018 13:09

deps: update nghttp2 to 1.34.0

f6cfc13

Key new feature: RFC 8441 `:protocol` support

http2: add RFC 8441 extended connect protocol support

5c008e8

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 5, 2018

jasnell added semver-minor PRs that contain new features and should be released in the next minor version. http2 Issues or PRs related to the http2 subsystem. labels Oct 5, 2018

refack approved these changes Oct 5, 2018

View reviewed changes

devsnek approved these changes Oct 5, 2018

View reviewed changes

addaleax approved these changes Oct 5, 2018

View reviewed changes

jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 6, 2018

cjihrig approved these changes Oct 6, 2018

View reviewed changes

trivikr approved these changes Oct 7, 2018

View reviewed changes

jasnell closed this Oct 8, 2018

targos mentioned this pull request Oct 10, 2018

Release proposal: v10.12.0 #23313

Merged

beevelop mentioned this pull request Oct 10, 2018

2018-10-10 Version 10.12.0 (Current) @targos beevelop/docker-nodejs#225

Closed

addaleax mentioned this pull request Oct 11, 2018

http2 websocket #15230

Closed

rahbari mentioned this pull request Oct 15, 2018

WebSocket over HTTP2 websockets/ws#1458

Open

addaleax mentioned this pull request Oct 20, 2018

http2: simplify timeout tracking #19206

Closed

2 tasks

ayZagen mentioned this pull request Dec 25, 2018

HTTP/2 Support SocketCluster/socketcluster#465

Open

analogrelay mentioned this pull request Apr 10, 2019

Kestrel support for WebSockets over HTTP/2 dotnet/aspnetcore#7801

Closed

BethGriggs mentioned this pull request Aug 15, 2019

V8.17.0 proposal #29151

Closed

BethGriggs removed the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 15, 2019

BethGriggs mentioned this pull request Aug 15, 2019

V8.16.1 proposal #29152

Merged

lbguilherme mentioned this pull request Feb 9, 2020

Streams sdkgen/sdkgen#5

Open

krizhanovsky mentioned this pull request Jun 6, 2022

Websocket tempesta-tech/tempesta#755

Closed

tamaina mentioned this pull request Apr 26, 2023

テスト環境で(httpsではない)httpで公開されているサーバー同士でもActivityPub通信がしたい misskey-dev/misskey#10716

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http2: add RFC 8441 extended connect protocol support #23284

http2: add RFC 8441 extended connect protocol support #23284

jasnell commented Oct 5, 2018

nodejs-github-bot commented Oct 5, 2018

devsnek left a comment

jasnell commented Oct 5, 2018

rauchg commented Oct 5, 2018

addaleax Oct 5, 2018

jasnell Oct 5, 2018

jasnell commented Oct 6, 2018

jasnell commented Oct 6, 2018

trivikr commented Oct 7, 2018 •

edited

Loading

trivikr left a comment

jasnell commented Oct 8, 2018

http2: add RFC 8441 extended connect protocol support #23284

http2: add RFC 8441 extended connect protocol support #23284

Conversation

jasnell commented Oct 5, 2018

Checklist

nodejs-github-bot commented Oct 5, 2018

devsnek left a comment

Choose a reason for hiding this comment

jasnell commented Oct 5, 2018

rauchg commented Oct 5, 2018

addaleax Oct 5, 2018

Choose a reason for hiding this comment

jasnell Oct 5, 2018

Choose a reason for hiding this comment

jasnell commented Oct 6, 2018

jasnell commented Oct 6, 2018

trivikr commented Oct 7, 2018 • edited Loading

trivikr left a comment

Choose a reason for hiding this comment

jasnell commented Oct 8, 2018

trivikr commented Oct 7, 2018 •

edited

Loading