-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test-require-symlink on Windows #23691
test: fix test-require-symlink on Windows #23691
Conversation
Shouldn't we validate the arg and throw, or assume |
@refack the API assumes We could add a test to see if link target is a directory and make it automatically use |
👍 (or throw) |
Resumed CI, all green: https://ci.nodejs.org/job/node-test-commit/22568/ |
So we actually don't get coverage for this in CI because of: |
Creating directory symlinks on Windows require 'dir' parameter to be provided. Fixes: nodejs#23596 PR-URL: nodejs#23691 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
0cbd76c
to
d1d5924
Compare
On Windows creating a symlink to a directory will not work unless extra 'dir' parameter is passed. This adds a check if link target is a directory, and if so automatically use 'dir' when creating symlink. Ref: nodejs#23691
On Windows creating a symlink to a directory will not work unless extra 'dir' parameter is passed. This adds a check if link target is a directory, and if so automatically use 'dir' when creating symlink. PR-URL: nodejs#23724 Refs: nodejs#23691 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
On Windows creating a symlink to a directory will not work unless extra 'dir' parameter is passed. This adds a check if link target is a directory, and if so automatically use 'dir' when creating symlink. PR-URL: nodejs#23724 Refs: nodejs#23691 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Creating directory symlinks on Windows require 'dir' parameter to be provided.
Fixes: #23596
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes