2018-10-30 Version 10.13.0 'Dubnium' (LTS) #23831

MylesBorins · 2018-10-23T14:22:44Z

2018-10-30, Version 10.13.0 'Dubnium' (LTS), @MylesBorins

This release marks the transition of Node.js 10.x into Long Term
Support (LTS) with the codename 'Dubnium'. The 10.x release line
now moves in to "Active LTS" and will remain so until April 2020.
After that time it will move in to "Maintenance" until end of
life in April 2021.

Notable Changes

This release only includes minimal changes necessary to fix known regressions prior to LTS.

Commits

[2ba6010082] - buffer: fix crash for invalid index types (Anna Henningsen)
[2cd68be69d] - build: spawn make test-ci with -j1 (Refael Ackermann) #23733
[1003f4c975] - deps: fix wrong default for v8 handle zapping (Refael Ackermann) #23801

nodejs-github-bot · 2018-10-23T14:22:47Z

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1340/pipeline

MylesBorins · 2018-10-23T14:23:58Z

@nodejs/release please lmk if you think we should include any changes in this release... we currently have a fairly decent backlog on staging, which I think includes semver-minor changes. While we could include them in this release it would arguably be against our LTS policy (as changes will not have been in a release for 2 weeks). We do not, afaik, have explicit policy around the initial LTS release... but have discussed in the past releasing only the bit flip to LTS rather than accompanying it with other changes

targos · 2018-10-23T14:28:15Z

I'm +1 on a release with minimal changes.

We should include #23801 when it lands

doc/changelogs/CHANGELOG_V10.md

targos · 2018-10-23T14:34:34Z

A test is failing: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel72-s390x/6488/testReport/junit/(root)/test/parallel_test_process_release/

mhdawson · 2018-10-23T14:57:41Z

Test is failing because it needs to be aware of the new release

// it's expected that future LTS release lines will have additional
// branches in here
if (versionParts[0] === '4' && versionParts[1] >= 2) {
  assert.strictEqual(process.release.lts, 'Argon');
} else if (versionParts[0] === '6' && versionParts[1] >= 9) {
  assert.strictEqual(process.release.lts, 'Boron');
} else if (versionParts[0] === '8' && versionParts[1] >= 9) {
  assert.strictEqual(process.release.lts, 'Carbon');
} else {
  assert.strictEqual(process.release.lts, undefined);
}

Missing the else if for 10

mhdawson

LGTM once test is updated.

cxreg · 2018-10-23T15:12:26Z

src/node_version.h

-#define NODE_VERSION_IS_LTS 0
-#define NODE_VERSION_LTS_CODENAME ""
+#define NODE_VERSION_IS_LTS 1
+#define NODE_VERSION_LTS_CODENAME "dubnium"


This codename is uppercased in Boron and Carbon. Is there a reason for a change to this naming pattern?

cxreg · 2018-10-23T15:32:19Z

@MylesBorins did you intend to rebase to v10.x-staging with that last commit?

MylesBorins · 2018-10-23T15:34:53Z

@cxreg I didn't, thanks for the due diligence

test/parallel/test-process-release.js

targos · 2018-10-24T14:08:30Z

Another change that should be included IMO: #23795

srl295 · 2018-10-24T18:24:26Z

edit no notable changes… OK, this can be next time.

maybe some ICU <3 ? in decreasing order of importance

ICU 63.1 deps: ICU4C 63.1 #23244
download retry doc: document and warn if the ICU version is too old #23766

Easily skip this one if ICU 63.1 lands:

significant digit workaround for ICU 62.1 - deps: icu: apply workaround patch to 62.1 for significant digits #23764 - this would ONLY help someone who explicitly compiles 10.x against icu 62.1. Already fixed in 63.1. Does include a regression test though.

bnb · 2018-10-25T14:30:02Z

Thank you for your work on this @MylesBorins ❤️

I also very much appreciate the precedent of "no changes" outside of a SemVer minor patch. Feels much tidier and provides a simple way to explain the change to people.

MylesBorins · 2018-10-25T15:50:02Z

@targos I've landed #23801 and am waiting to see what happens in #23795

@srl295 I'm going to push back on landing any of the changes you've outlined here. As we are keeping this release targeting to minimal changes. I'd like to see the changes above live in an 11.x release before landing them in LTS

PR-URL: #23801 Fixes: #23796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

MylesBorins · 2018-10-25T15:56:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/18152/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1600/

rc.1: https://nodejs.org/download/rc/v10.13.0-rc.1/:

cujarrett · 2018-10-28T17:17:40Z

🎉 Thanks Node contributors and maintainers! 🎉

All the sub targets have internal parallelism, so no performance loss. Also `make` doesn't to a good enough job of combining the output streams, or eliminate races. PR-URL: #23733 Fixes: #22006 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

2555cb4 introduced a crash when a non-number value was passed to `ParseArrayIndex()`. We do not always have JS typechecking for that in place, though. This returns back to the previous behavior of coercing values to integers, which is certainly questionable. Refs: #22129 Fixes: #23668

MylesBorins · 2018-10-29T19:45:29Z

updated with two more commits to fix known regressions. Kicking off one last round of CI

CI: https://ci.nodejs.org/job/node-test-pull-request/18216/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1605/
rc.2: https://nodejs.org/download/rc/v10.13.0-rc.2/

MylesBorins · 2018-10-30T04:07:35Z

Rebuilding OSX: https://ci.nodejs.org/job/node-test-commit-osx/22254/

This release marks the transition of Node.js 10.x into Long Term Support (LTS) with the codename 'Dubnium'. The 10.x release line now moves in to "Active LTS" and will remain so until April 2020. After that time it will move in to "Maintenance" until end of life in April 2021. Notable Changes: This release only includes minimal changes necessary to fix known regressions prior to LTS. PR-URL: #23831

PR-URL: #23831

This release marks the transition of Node.js 10.x into Long Term Support (LTS) with the codename 'Dubnium'. The 10.x release line now moves in to "Active LTS" and will remain so until April 2020. After that time it will move in to "Maintenance" until end of life in April 2021. Notable Changes: This release only includes minimal changes necessary to fix known regressions prior to LTS. PR-URL: nodejs#23831

targos · 2018-10-30T09:00:59Z

🎉 🎉 🎉

joshgav · 2018-10-30T18:43:56Z

Thanks @MylesBorins! I think you still need to add a latest-dubnium folder to https://nodejs.org/dist/.

richardlau · 2018-10-30T18:59:05Z

Thanks @MylesBorins! I think you still need to add a latest-dubnium folder to https://nodejs.org/dist/.

Opened nodejs/nodejs-latest-linker#2 against the linker tool.

MylesBorins · 2018-10-31T07:57:19Z

I manually created https://nodejs.org/download/release/latest-dubnium/ but we still need to update the automation script

rvagg · 2018-10-31T18:16:31Z

latest-linker updated and deployed, thanks @richardlau for the code and @joshgav for the ping

nodejs-github-bot added meta Issues and PRs related to the general management of the project. v10.x labels Oct 23, 2018

richardlau approved these changes Oct 23, 2018

View reviewed changes

vsemozhetbyt reviewed Oct 23, 2018

View reviewed changes

doc/changelogs/CHANGELOG_V10.md Outdated Show resolved Hide resolved

MylesBorins mentioned this pull request Oct 23, 2018

v10.x initial LTS release nodejs/Release#374

Closed

cjihrig approved these changes Oct 23, 2018

View reviewed changes

mhdawson approved these changes Oct 23, 2018

View reviewed changes

cxreg reviewed Oct 23, 2018

View reviewed changes

MylesBorins force-pushed the v10.13.0-proposal branch from 3ef9e25 to fe93064 Compare October 23, 2018 15:14

MylesBorins force-pushed the v10.13.0-proposal branch from fe93064 to f336836 Compare October 23, 2018 15:34

richardlau reviewed Oct 23, 2018

View reviewed changes

test/parallel/test-process-release.js Outdated Show resolved Hide resolved

lpinca approved these changes Oct 23, 2018

View reviewed changes

srl295 approved these changes Oct 24, 2018

View reviewed changes

deps: fix wrong default for v8 handle zapping

1003f4c

PR-URL: #23801 Fixes: #23796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

MylesBorins force-pushed the v10.13.0-proposal branch from c97612a to 80cd8f3 Compare October 25, 2018 15:54

orangejulius mentioned this pull request Oct 27, 2018

Upgrade Node.js to version 10.13.0 (LTS) pelias/docker-baseimage#10

Merged

MylesBorins force-pushed the v10.13.0-proposal branch from 80cd8f3 to dc2708a Compare October 29, 2018 19:41

MylesBorins force-pushed the v10.13.0-proposal branch from dc2708a to ab4af08 Compare October 30, 2018 06:21

MylesBorins merged commit ab4af08 into v10.x Oct 30, 2018

MylesBorins added a commit that referenced this pull request Oct 30, 2018

Working on v10.13.1

4febb6c

PR-URL: #23831

richardlau mentioned this pull request Oct 30, 2018

add Node.js 10 LTS dubnium nodejs/nodejs-latest-linker#2

Merged

targos deleted the v10.13.0-proposal branch October 31, 2018 08:38

codebytere mentioned this pull request Nov 27, 2018

v10.13.1 proposal #24675

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2018-10-30 Version 10.13.0 'Dubnium' (LTS) #23831

2018-10-30 Version 10.13.0 'Dubnium' (LTS) #23831

MylesBorins commented Oct 23, 2018 •

edited

Loading

nodejs-github-bot commented Oct 23, 2018

MylesBorins commented Oct 23, 2018

targos commented Oct 23, 2018

targos commented Oct 23, 2018

mhdawson commented Oct 23, 2018

mhdawson left a comment

cxreg Oct 23, 2018

MylesBorins Oct 23, 2018

cxreg commented Oct 23, 2018

MylesBorins commented Oct 23, 2018

targos commented Oct 24, 2018

srl295 commented Oct 24, 2018 •

edited

Loading

bnb commented Oct 25, 2018

MylesBorins commented Oct 25, 2018

MylesBorins commented Oct 25, 2018

cujarrett commented Oct 28, 2018 •

edited

Loading

MylesBorins commented Oct 29, 2018

MylesBorins commented Oct 30, 2018

targos commented Oct 30, 2018

joshgav commented Oct 30, 2018

richardlau commented Oct 30, 2018

MylesBorins commented Oct 31, 2018

rvagg commented Oct 31, 2018

2018-10-30 Version 10.13.0 'Dubnium' (LTS) #23831

2018-10-30 Version 10.13.0 'Dubnium' (LTS) #23831

Conversation

MylesBorins commented Oct 23, 2018 • edited Loading

2018-10-30, Version 10.13.0 'Dubnium' (LTS), @MylesBorins

Notable Changes

Commits

nodejs-github-bot commented Oct 23, 2018

MylesBorins commented Oct 23, 2018

targos commented Oct 23, 2018

targos commented Oct 23, 2018

mhdawson commented Oct 23, 2018

mhdawson left a comment

Choose a reason for hiding this comment

cxreg Oct 23, 2018

Choose a reason for hiding this comment

MylesBorins Oct 23, 2018

Choose a reason for hiding this comment

cxreg commented Oct 23, 2018

MylesBorins commented Oct 23, 2018

targos commented Oct 24, 2018

srl295 commented Oct 24, 2018 • edited Loading

edit no notable changes… OK, this can be next time.

bnb commented Oct 25, 2018

MylesBorins commented Oct 25, 2018

MylesBorins commented Oct 25, 2018

cujarrett commented Oct 28, 2018 • edited Loading

MylesBorins commented Oct 29, 2018

MylesBorins commented Oct 30, 2018

targos commented Oct 30, 2018

joshgav commented Oct 30, 2018

richardlau commented Oct 30, 2018

MylesBorins commented Oct 31, 2018

rvagg commented Oct 31, 2018

MylesBorins commented Oct 23, 2018 •

edited

Loading

srl295 commented Oct 24, 2018 •

edited

Loading

cujarrett commented Oct 28, 2018 •

edited

Loading