-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: check minimum ICU in configure for system-icu #24255
Conversation
else you get this:
also updates 'icu_system_version': '60.2',
'icu_ver_major': '60', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If nothing uses/is going to use icu_system_version
, can you remove it?
@bnoordhuis I'll remove |
@bnoordhuis thanks. I think I addressed your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment.
@srl295 Looks like there's one nit from @bnoordhuis and a CI run and otherwise this is landable? Does that seem right to you? |
6695e84
to
2d0d9ce
Compare
2d0d9ce
to
5c47c2b
Compare
- check the version number coming out of pkg-config PR-URL: nodejs#24255 Fixes: nodejs#24253 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
5c47c2b
to
ed1c40e
Compare
Fixes: #24253
make -j4 test
(UNIX), orvcbuild test
(Windows) passes