Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: check minimum ICU in configure for system-icu #24255

Merged
merged 1 commit into from
Nov 17, 2018
Merged

build: check minimum ICU in configure for system-icu #24255

merged 1 commit into from
Nov 17, 2018

Commits on Nov 17, 2018

  1. build: check minimum ICU in configure for system-icu 

    - check the version number coming out of pkg-config

PR-URL: nodejs#24255
Fixes: nodejs#24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @srl295 @refack
    srl295 authored and refack committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    ed1c40e View commit details
    Browse the repository at this point in the history