doc: add help on fixing IPv6 test failures #24372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took me a while to figure out the problem and then some googling to find the right answer. I think it is worth adding this to help other people in the future and to have an easy place to point people to for the solution if their test run fails with IPv6 failures.
nodejs-github-bot
added
build
Co-Authored-By: mhdawson <michael_dawson@ca.ibm.com>
Co-Authored-By: mhdawson <michael_dawson@ca.ibm.com>
Co-Authored-By: mhdawson <michael_dawson@ca.ibm.com>
|
@vsemozhetbyt thanks for the review, accepted all of your suggestions. |
thefourtheye
approved these changes
Nov 15, 2018
BUILDING.md
Outdated
| on Ubuntu that does not seem to be the case. '::1' can be enabled on the | ||
| loopback interface on Ubuntu using: | ||
|
|
||
| `sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=0` |
There was a problem hiding this comment.
Nit: It would be better if we formatted this as console text, instead of inline code.
|
@vsemozhetbyt any chance you can add your approval as well? |
lpinca
approved these changes
Nov 15, 2018
Trott
reviewed
Nov 16, 2018
Trott
reviewed
Nov 16, 2018
BUILDING.md
Outdated
| The tests attempt to detect support for IPv6 and exclude IPv6 tests if | ||
| appropriate. However, if your main interface has IPv6 addresses then your | ||
| loopback interface must also have '::1' enabled. For some default installations | ||
| on Ubuntu that does not seem to be the case. '::1' can be enabled on the |
There was a problem hiding this comment.
Suggested change
| on Ubuntu that does not seem to be the case. '::1' can be enabled on the | |
| on Ubuntu, that does not seem to be the case. '::1' can be enabled on the |
Trott
reviewed
Nov 16, 2018
BUILDING.md
Outdated
| appropriate. However, if your main interface has IPv6 addresses then your | ||
| loopback interface must also have '::1' enabled. For some default installations | ||
| on Ubuntu that does not seem to be the case. '::1' can be enabled on the | ||
| loopback interface on Ubuntu using: |
There was a problem hiding this comment.
Replace the last sentence with this?
To enable '::1' on the loopback interface on Ubuntu:
There was a problem hiding this comment.
I'm sure I had something like "You can .." but guidance is not to use you. :)
fhinkel
approved these changes
Nov 16, 2018
BUILDING.md
Outdated
| appropriate. However, if your main interface has IPv6 addresses then your | ||
| loopback interface must also have '::1' enabled. For some default installations | ||
| on Ubuntu that does not seem to be the case. '::1' can be enabled on the | ||
| loopback interface on Ubuntu using: |
Co-Authored-By: mhdawson <michael_dawson@ca.ibm.com>
|
Comments addressed. Like CI run: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1632/ |
|
CI good landing. |
|
Landed as 6b4e413 |
mhdawson
added a commit
that referenced
this pull request
Nov 16, 2018
It took me a while to figure out the problem and then some googling to find the right answer. I think it is worth adding this to help other people in the future and to have an easy place to point people to for the solution if their test run fails with IPv6 failures. PR-URL: #24372 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
It took me a while to figure out the problem and then some googling to find the right answer. I think it is worth adding this to help other people in the future and to have an easy place to point people to for the solution if their test run fails with IPv6 failures. PR-URL: #24372 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
It took me a while to figure out the problem and then some googling to find the right answer. I think it is worth adding this to help other people in the future and to have an easy place to point people to for the solution if their test run fails with IPv6 failures. PR-URL: #24372 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to figure out the problem and
then some googling to find the right answer. I think
it is worth adding this to help other people in the
future and to have an easy place to point people to
for the solution if their test run fails with IPv6
failures.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes