Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add help on fixing IPv6 test failures #24372

Closed
wants to merge 7 commits into from
Closed

doc: add help on fixing IPv6 test failures #24372

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
db56b46
doc: add help on fixing IPv6 test failures
mhdawson Nov 14, 2018
60caa23
squash: accept suggestion
vsemozhetbyt Nov 15, 2018
5fe1c41
squash: accept suggestion
vsemozhetbyt Nov 15, 2018
45d4a58
squash: accept suggestion
vsemozhetbyt Nov 15, 2018
5087aac
squash: address comments
mhdawson Nov 15, 2018
e51ba22
squash: address changes
Trott Nov 16, 2018
0aaae27
squash: address comments
mhdawson Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,14 @@ $ ./node ./test/parallel/test-stream2-transform.js
Remember to recompile with `make -j4` in between test runs if you change code in
the `lib` or `src` directories.

The tests attempt to detect support for IPv6 and exclude IPv6 tests if
appropriate. However, if your main interface has IPv6 addresses then your
mhdawson marked this conversation as resolved.
Show resolved Hide resolved
loopback interface must also have '::1' enabled. For some default installations
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on Ubuntu that does not seem to be the case. '::1' can be enabled on the
on Ubuntu, that does not seem to be the case. '::1' can be enabled on the

loopback interface on Ubuntu using:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the last sentence with this?

To enable '::1' on the loopback interface on Ubuntu:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least

You can enable...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure I had something like "You can .." but guidance is not to use you. :)


`sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=0`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be better if we formatted this as console text, instead of inline code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


#### Running Coverage

It's good practice to ensure any code you add or change is covered by tests.
Expand Down