Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x] deps,v8: cherry pick 6e101b044eb49b45280d043624d911567ccca163 #24555

Closed
wants to merge 1 commit into from

Commits on Nov 23, 2018

  1. deps: cherry-pick 2987946 from upstream V8

    Original commit message:
    
        Stop manual unescaping of script source data when preprocessing logs.
    
        It appears that the fields are already being unescaped elsewhere,
        perhaps by the JSON writer. So if we unescape when adding the source
        filename and contents, unescaping will happen again later and plain
        backslashes will be interpreted as escape codes.
    
        Bug: v8:6240
        Change-Id: Ic66b9017ae685d6dd12944ee8d254991e26fbd32
        Reviewed-on: https://chromium-review.googlesource.com/1186625
        Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
        Commit-Queue: Bret Sepulveda <bsep@chromium.org>
        Cr-Commit-Position: refs/heads/master@{nodejs#55401}
    
    Refs: v8/v8@2987946
    refack committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    aa98452 View commit details
    Browse the repository at this point in the history