test: make test-node-output-v8-warning more flexible
#55401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
codebytere
force-pushed
the
output-warning-more-generic
branch
from
0e9b98d
to
b1fecba
Compare
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55401 +/- ##
==========================================
+ Coverage 88.23% 88.41% +0.18%
==========================================
Files 652 652
Lines 183911 186918 +3007
Branches 35858 36074 +216
==========================================
+ Hits 162271 165270 +2999
+ Misses 14916 14889 -27
- Partials 6724 6759 +35 |
lpinca
approved these changes
Oct 18, 2024
codebytere
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55401 ✔ Done loading data for nodejs/node/pull/55401 ----------------------------------- PR info ------------------------------------ Title test: make `test-node-output-v8-warning` more flexible (#55401) Author Shelley Vohr <shelley.vohr@gmail.com> (@codebytere) Branch codebytere:output-warning-more-generic -> nodejs:main Labels test Commits 1 - test: make test-node-output-v8-warning more flexible Committers 1 - Shelley Vohr <shelley.vohr@gmail.com> PR-URL: https://github.com/nodejs/node/pull/55401 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55401 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 16 Oct 2024 08:27:53 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55401#pullrequestreview-2378922487 ✘ This PR needs to wait 19 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-18T20:33:39Z: https://ci.nodejs.org/job/node-test-pull-request/63191/ - Querying data for job/node-test-pull-request/63191/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11460601806 |
richardlau
approved these changes
Oct 22, 2024
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d448368 |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2024
PR-URL: #55401 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55401 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55401 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes snapshot testing slightly more flexible so that embedders can run smoke tests against it.
Previous similar PRs: