Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V23.1.0 proposal #55513

Merged
merged 93 commits into from
Oct 24, 2024
Merged

V23.1.0 proposal #55513

merged 93 commits into from
Oct 24, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 24, 2024

Buffer now work with resizable ArrayBuffer

When a Buffer is created using a resizable ArrayBuffer, the Buffer length
will now correctly change as the underlying ArrayBuffer size is changed.

const ab = new ArrayBuffer(10, { maxByteLength: 20 });
const buffer = Buffer.from(ab);
console.log(buffer.byteLength); 10
ab.resize(15);
console.log(buffer.byteLength); 15
ab.resize(5);
console.log(buffer.byteLength); 5

Contributed by James M Snell in #55377.

MockTimers test runner API is now stable

MockTimers, introduced in April 2023, has just reached stable status. This
API provides comprehensive support for mocking Date and all major timers in
Node.js, including setTimeout, setInterval, and setImmediate, both from
the node:timers, node:timers/promises modules and global objects. After
months of refinement, developers can now fully rely on MockTimers for testing
time-based operations with confidence, ensuring better control over asynchronous
behavior in their Node.js applications.

Example usage with initial Date object as time set:

import { mock } from 'node:test';
mock.timers.enable({ apis: ['Date'], now: new Date('1970-01-01') });

Contributed by Erick Wendel in #55398.

JSON modules and import attributes are now stable

The two proposals reached stage 4 of the TC39 process, at the October 2024
meeting. The Node.js implementation already matches exactly the semantics
required by the proposals.

Contributed by Nicolò Ribaudo by #55333.

Other Notable Changes

  • [4ba31b7f20] - (SEMVER-MINOR) assert: make assertion_error use Myers diff algorithm (Giovanni Bucci) #54862
  • [dcbc5fbe65] - (SEMVER-MINOR) lib: add UV_UDP_REUSEPORT for udp (theanarkh) #55403
  • [ec867ac7ce] - (SEMVER-MINOR) net: add UV_TCP_REUSEPORT for tcp (theanarkh) #55408
Commits
  • [4ba31b7f20] - (SEMVER-MINOR) assert: make assertion_error use Myers diff algorithm (Giovanni Bucci) #54862
  • [fe667bea28] - assert: fix deepEqual always return true on URL (Xuguang Mei) #50853
  • [aca03d9083] - benchmark: add --runs support to run.js (Rafael Gonzaga) #55158
  • [c5abf50692] - benchmark: adjust byte size for buffer-copy (Rafael Gonzaga) #55295
  • [d3618b2334] - benchmark: adjust config for deepEqual object (Rafael Gonzaga) #55254
  • [c05582da3d] - (SEMVER-MINOR) buffer: make Buffer work with resizable ArrayBuffer (James M Snell) #55377
  • [194bb0fca5] - build: fix GN build for cares/uv deps (Cheng) #55477
  • [8eb5359592] - build: fix uninstall script for AIX 7.1 (Cloorc) #55438
  • [32f7d5ad1c] - build: conditionally compile bundled sqlite (Richard Lau) #55409
  • [2147e496e7] - build: tidy up cares.gyp (Richard Lau) #55445
  • [2beae50c77] - build: synchronize list of c-ares source files (Richard Lau) #55445
  • [f48d30eb9f] - build: fix path concatenation (Mohammed Keyvanzadeh) #55387
  • [d42522eec5] - build: fix make errors that occur in Makefile (minkyu_kim) #55287
  • [52da293471] - cli: add --heap-prof flag available to NODE_OPTIONS (Juan José) #54259
  • [adead26815] - crypto: include openssl/rand.h explicitly (Shelley Vohr) #55425
  • [df2f1adf9e] - deps: V8: cherry-pick f915fa4c9f41 (Chengzhong Wu) #55484
  • [bfc10a975f] - deps: update googletest to df1544b (Node.js GitHub Bot) #55465
  • [45ef1809bd] - deps: update c-ares to v1.34.2 (Node.js GitHub Bot) #55463
  • [c2b5ebfeca] - deps: update ada to 2.9.1 (Node.js GitHub Bot) #54679
  • [903863cafa] - deps: update simdutf to 5.6.0 (Node.js GitHub Bot) #55379
  • [008fb5f7f4] - deps: patch V8 to 12.9.202.28 (Node.js GitHub Bot) #55371
  • [8b282228ae] - deps: update c-ares to v1.34.1 (Node.js GitHub Bot) #55369
  • [54d55f2337] - Revert "deps: disable io_uring support in libuv by default" (Santiago Gimeno) #55114
  • [bfb3c621c4] - deps: update libuv to 1.49.1 (Santiago Gimeno) #55114
  • [055d2b8919] - deps: update amaro to 0.1.9 (Node.js GitHub Bot) #55348
  • [c028d21b44] - diagnostics_channel: fix unsubscribe during publish (simon-id) #55116
  • [b4b6ddb777] - dns: honor the order option (Luigi Pinca) #55392
  • [37352cef7f] - doc: changed the command used to verify SHASUMS256 (adriancuadrado) #55420
  • [66bcf4c065] - doc: move dual package shipping docs to separate repo (Joyee Cheung) #55444
  • [04b41bda03] - doc: add note about stdio streams in child_process (Ederin (Ed) Igharoro) #55322
  • [689d3a3e41] - doc: add isBigIntObject to documentation (leviscar) #55450
  • [784c825a27] - doc: remove outdated remarks about highWaterMark in fs (Ian Kerins) #55462
  • [1ec25e8573] - doc: move Danielle Adams key to old gpg keys (RafaelGSS) #55399
  • [7d5bb097eb] - doc: move Bryan English key to old gpg keys (RafaelGSS) #55399
  • [2967471f67] - doc: move Beth Griggs keys to old gpg keys (RafaelGSS) #55399
  • [0be3a7505f] - doc: add changelog for mocktimers (Erick Wendel) #55398
  • [e15f779794] - doc: spell out condition restrictions (Jan Martin) #55187
  • [c3f2216a7d] - doc: add instructions for WinGet build (Hüseyin Açacak) #55356
  • [bdc2c3bb94] - doc: add missing return values in buffer docs (Karl Horky) #55273
  • [41f68f59af] - doc: fix ambasador markdown list (Rafael Gonzaga) #55361
  • [bbd5318729] - esm: add a fallback when importer in not a file (Antoine du Hamel) #55471
  • [22d77773fd] - esm: fix inconsistency with importAssertion in resolve hook (Wei Zhu) #55365
  • [48bb87b059] - esm: mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
  • [8ceefebaf2] - events: optimize EventTarget.addEventListener (Robert Nagy) #55312
  • [45f960cab6] - fs: pass correct path to DirentFromStats during glob (Aviv Keller) #55071
  • [d9494a7641] - fs: use wstring on Windows paths (jazelly) #55171
  • [0f1d13e359] - lib: ensure FORCE_COLOR forces color output in non-TTY environments (Pietro Marchini) #55404
  • [dcbc5fbe65] - (SEMVER-MINOR) lib: add UV_UDP_REUSEPORT for udp (theanarkh) #55403
  • [714f272423] - lib: remove startsWith/endsWith primordials for char checks (Gürgün Dayıoğlu) #55407
  • [4e5c90bb41] - lib: replace createDeferredPromise util with Promise.withResolvers (Yagiz Nizipli) #54836
  • [db18aca47a] - lib: add flag to drop connection when running in cluster mode (theanarkh) #54927
  • [dd848f2d1e] - lib: test_runner#mock:timers respeced timeout_max behaviour (BadKey) #55375
  • [a9473bb8e3] - lib: remove settled dependant signals when they are GCed (Edigleysson Silva (Edy)) #55354
  • [07ad987aa1] - lib: convert transfer sequence to array in js (Jason Zhang) #55317
  • [d54d3b24c3] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #55381
  • [12d709bd27] - meta: assign CODEOWNERS for /deps/ncrypto/* (Filip Skokan) #55426
  • [0130780eec] - meta: change color to blue notify review-wanted (Rafael Gonzaga) #55423
  • [335a507027] - meta: bump codecov/codecov-action from 4.5.0 to 4.6.0 (dependabot[bot]) #55222
  • [5ffc721d09] - meta: bump github/codeql-action from 3.26.6 to 3.26.10 (dependabot[bot]) #55221
  • [d9fde2c45b] - meta: bump step-security/harden-runner from 2.9.1 to 2.10.1 (dependabot[bot]) #55220
  • [2c960a212e] - module: include module information in require(esm) warning (Joyee Cheung) #55397
  • [a12dbf03d9] - module: simplify ts under node_modules check (Marco Ippolito) #55440
  • [ec867ac7ce] - (SEMVER-MINOR) net: add UV_TCP_REUSEPORT for tcp (theanarkh) #55408
  • [9e320279a2] - Revert "path: fix bugs and inconsistencies" (Aviv Keller) #55414
  • [1ce8928db3] - sqlite: cache column names in stmt.all() (Fedor Indutny) #55373
  • [cc775d314a] - src: switch from Get/SetPrototype to Get/SetPrototypeV2 (Aviv Keller) #55453
  • [89c96ade53] - src: remove icu based ToASCII and ToUnicode (Yagiz Nizipli) #55156
  • [57dbbf8402] - src: fix winapi_strerror error string (Hüseyin Açacak) #55207
  • [a490bb8745] - src: remove uv__node_patch_is_using_io_uring (Santiago Gimeno) #55114
  • [0da1632937] - src,lib: introduce util.getSystemErrorMessage(err) (Juan José) #54075
  • [6764273127] - stream: propagate AbortSignal reason (Marvin ROGER) #55473
  • [4dc2791cdd] - test: add repl preview timeout test (Chengzhong Wu) #55484
  • [8634e054d4] - test: make test-node-output-v8-warning more flexible (Shelley Vohr) #55401
  • [6c8564b55d] - test: fix addons and node-api test assumptions (Antoine du Hamel) #55441
  • [94e863cdb7] - test: update wpt test for webmessaging/broadcastchannel (devstone) #55205
  • [c10c6715cd] - test: deflake test-cluster-shared-handle-bind-privileged-port (Aviv Keller) #55378
  • [6f7379a048] - test: fix invalid file: URL in test-fs-path-dir (Antoine du Hamel) #55454
  • [dd5a08d022] - test: update console wpt (Aviv Keller) #55192
  • [9b7b4a6b25] - test: remove duplicate tests (Luigi Pinca) #55393
  • [eb2fab3da1] - test: update test_util.cc for coverage (minkyu_kim) #55291
  • [59923d137e] - test: update compression wpt (Aviv Keller) #55191
  • [1b63a822ac] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #55427
  • [97c6448f63] - test_runner: mark mockTimers as stable (Erick Wendel) #55398
  • [69ee56aacd] - test_runner: add support for scheduler.wait on mock timers (Erick Wendel) #55244
  • [d9f0407cf6] - test_runner: require --enable-source-maps for sourcemap coverage (Aviv Keller) #55359
  • [2ac2c5a7e7] - tools: update lint-md-dependencies (Node.js GitHub Bot) #55470
  • [10f6b90f7d] - tools: update gyp-next to 0.18.3 (Node.js GitHub Bot) #55464
  • [65936a8bb6] - tools: add script to synch c-ares source lists (Richard Lau) #55445
  • [1da4168486] - tools: add polyfilled option to prefer-primordials rule (Antoine du Hamel) #55318
  • [3b2b3a8df2] - tools: fix typos (Nathan Baulch) #55061
  • [736c085a5d] - typings: add missing type of ArrayBufferPrototypeGetByteLength (Wuli Zuo) #55439
  • [7b3e38b855] - url: handle "unsafe" characters properly in pathToFileURL (Antoine du Hamel) #54545

RafaelGSS and others added 30 commits October 19, 2024 10:54
This should make easier to read on benchmark/compare
and when generating graphs

PR-URL: #55254
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.9.1 to 2.10.1.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@5c7944e...91182cc)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #55220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.6 to 3.26.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4dd1613...e2b3eaf)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #55221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@e28ff12...b9fd7d1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #55222
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55191
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55348
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
The two proposals reached stage 4 at the October 2024 meeting.

PR-URL: #55333
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #50853
Fixes: #50836
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit lets `tranfer` passed to `structuredClone` get validated at
JS layer by doing webidl conversion. This avoids the C++ to JS function
call overhead in the native implementaiton of `structuredClone`

PR-URL: #55317
Fixes: #55280
Refs: #50330
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
PR-URL: #55361
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #55273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
fix make errors that occur in
 coverage-clean case and coverage-test in Makefile

PR-URL: #55287
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
update test_util.cc for code coverage src/util-inl.h:PopFront()

PR-URL: #55291
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: https://github.com/libuv/libuv/releases/tag/v1.49.1
PR-URL: #55114
Refs: https://github.com/libuv/libuv/releases/tag/v1.49.0
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This reverts commit 42e659c.

PR-URL: #55114
Refs: https://github.com/libuv/libuv/releases/tag/v1.49.0
Refs: https://github.com/libuv/libuv/releases/tag/v1.49.1
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
As now the `SQPOLL` ring used in the libuv io_uring implementation is
disabled by default.
Also modify `UvMightBeUsingIoUring()` to just handle the case where
`Node.js` is dynamically linked to a `libuv` version which has the
`SQPOLL` ring enabled.

PR-URL: #55114
Refs: https://github.com/libuv/libuv/releases/tag/v1.49.0
Refs: https://github.com/libuv/libuv/releases/tag/v1.49.1
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55312
Fixes: #55311
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #55116
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
PR-URL: #55295
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55359
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #55354
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #55369
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Refs: v8/v8@12.9.202.26...12.9.202.28
PR-URL: #55371
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Fixes: #23191
PR-URL: #55207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55356
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
While the statement is running, it is impossible to modify the column
names and thus it is beneficial to create the host-language (JS) keys
once per all rows and reuse them for all results.

With this change the performance of `.all()` improves by around 25%
depending on the number of columns and rows in the result.

PR-URL: #55373
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #55375
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
PR-URL: #55061
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: #52195
PR-URL: #55377
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #55379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch. labels Oct 24, 2024
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. strip-types Issues or PRs related to strip-types support labels Oct 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2024

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Notable changes:

assert:
  * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862
buffer:
  * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
lib:
  * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403
net:
  * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408
test_runner:
  * mark `MockTimers` as stable (Erick Wendel) #55398

PR-URL: #55513
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (80c8998) to head (17fae65).
Report is 95 commits behind head on v23.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            v23.x   #55513      +/-   ##
==========================================
+ Coverage   88.40%   88.42%   +0.01%     
==========================================
  Files         652      653       +1     
  Lines      186784   187479     +695     
  Branches    36056    36089      +33     
==========================================
+ Hits       165130   165769     +639     
- Misses      14903    14955      +52     
- Partials     6751     6755       +4     
Files with missing lines Coverage Δ
lib/_http_agent.js 98.17% <ø> (ø)
lib/buffer.js 100.00% <ø> (ø)
lib/child_process.js 97.72% <ø> (ø)
lib/dgram.js 97.33% <ø> (+0.01%) ⬆️
lib/diagnostics_channel.js 99.08% <ø> (+0.01%) ⬆️

... and 141 files with indirect coverage changes

@RedYetiDev RedYetiDev added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. labels Oct 24, 2024
@aduh95 aduh95 merged commit 17fae65 into v23.x Oct 24, 2024
21 checks passed
@aduh95 aduh95 deleted the v23.1.0-proposal branch October 24, 2024 21:25
aduh95 added a commit that referenced this pull request Oct 24, 2024
aduh95 added a commit that referenced this pull request Oct 24, 2024
Notable changes:

assert:
  * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862
buffer:
  * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
lib:
  * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403
net:
  * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408
test_runner:
  * mark `MockTimers` as stable (Erick Wendel) #55398

PR-URL: #55513
aduh95 added a commit to aduh95/nodejs.org that referenced this pull request Oct 24, 2024
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Oct 24, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
Notable changes:

assert:
  * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) nodejs#54862
buffer:
  * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) nodejs#55377
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) nodejs#55333
lib:
  * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) nodejs#55403
net:
  * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) nodejs#55408
test_runner:
  * mark `MockTimers` as stable (Erick Wendel) nodejs#55398

PR-URL: nodejs#55513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.