Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: add missing type of ArrayBufferPrototypeGetByteLength #55439

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

iwuliz
Copy link
Contributor

@iwuliz iwuliz commented Oct 18, 2024

The type of ArrayBufferPrototypeGetByteLength was missing in primordials.d.ts.

@iwuliz iwuliz changed the title typings: Add missing type of ArrayBufferPrototypeGetByteLength typings: add missing type of ArrayBufferPrototypeGetByteLength Oct 18, 2024
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 864ff62 into nodejs:main Oct 22, 2024
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 864ff62

@iwuliz iwuliz deleted the add-missing-type branch October 22, 2024 10:31
aduh95 pushed a commit that referenced this pull request Oct 23, 2024
PR-URL: #55439
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55439
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55439
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants