doc: add instructions for WinGet build #55356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
lpinca
approved these changes
Oct 11, 2024
RedYetiDev
added
windows
|
IIUC not all windows builds come with winget preinstalled. If I'm correct, can you an add a link to where to download winget? (IIRC Microsoft has an app) |
benjamingr
approved these changes
Oct 13, 2024
huseyinacacak-janea
force-pushed
the
huseyin-00001-add-documentation-devhome
branch
from
436c927
to
81d71ff
Compare
Thank you. I've added a link. |
StefanStojanovic
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55356 ✔ Done loading data for nodejs/node/pull/55356 ----------------------------------- PR info ------------------------------------ Title doc: add instructions for WinGet build (#55356) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch huseyinacacak-janea:huseyin-00001-add-documentation-devhome -> nodejs:main Labels doc, windows, build, author ready Commits 2 - doc: add instructions for WinGet build - doc: add instructions for WinGet build Committers 1 - Hüseyin Açacak <huseyin@janeasystems.com> PR-URL: https://github.com/nodejs/node/pull/55356 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55356 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: add instructions for WinGet build ⚠ - doc: add instructions for WinGet build ℹ This PR was created on Fri, 11 Oct 2024 10:53:28 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55356#pullrequestreview-2363082788 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/55356#pullrequestreview-2364965986 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11344878431 |
huseyinacacak-janea
force-pushed
the
huseyin-00001-add-documentation-devhome
branch
from
28aeabf
to
267a0da
Compare
RedYetiDev
removed
the
commit-queue-failed
StefanStojanovic
approved these changes
Oct 15, 2024
StefanStojanovic
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 14f2db9 |
aduh95
pushed a commit
that referenced
this pull request
Oct 19, 2024
PR-URL: #55356 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55356 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added instructions on how to use WinGet configuration files to install the prerequisites for Node.js development on Windows.