dgram: add UV_UDP_REUSEPORT for udp #55403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
theanarkh
force-pushed
the
add_reuseport_for_udp
branch
from
023beb9
to
be29823
Compare
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55403 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.02%
==========================================
Files 652 653 +1
Lines 186878 187491 +613
Branches 36061 36094 +33
==========================================
+ Hits 165236 165751 +515
- Misses 14895 14970 +75
- Partials 6747 6770 +23
|
theanarkh
force-pushed
the
add_reuseport_for_udp
branch
from
be29823
to
cc1cc30
Compare
github-actions
bot
removed
the
request-ci
theanarkh
force-pushed
the
add_reuseport_for_udp
branch
2 times, most recently
from
249aa05
to
67bc2db
Compare
theanarkh
force-pushed
the
add_reuseport_for_udp
branch
from
67bc2db
to
42298db
Compare
github-actions
bot
removed
the
request-ci
theanarkh
added
the
author ready
|
Title should be |
theanarkh
changed the title
theanarkh
force-pushed
the
add_reuseport_for_udp
branch
from
42298db
to
6eda250
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
reviewed
Oct 19, 2024
theanarkh
force-pushed
the
add_reuseport_for_udp
branch
from
6eda250
to
c563569
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Oct 20, 2024
theanarkh
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6a02c27 |
lpinca
added
the
semver-minor
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2024
PR-URL: #55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
added a commit
that referenced
this pull request
Oct 24, 2024
Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) #55398 PR-URL: TODO
Merged
aduh95
added a commit
that referenced
this pull request
Oct 24, 2024
Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) #55398 PR-URL: #55513
aduh95
added a commit
that referenced
this pull request
Oct 24, 2024
Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) #55398 PR-URL: #55513
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) nodejs#54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) nodejs#55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) nodejs#55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) nodejs#55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) nodejs#55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) nodejs#55398 PR-URL: nodejs#55513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UV_UDP_REUSEPORTallows users to bind a port to multiple sockets.Refs: libuv/libuv#4419
make -j4 test(UNIX), orvcbuild test(Windows) passes