-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: enforce strict policy to semver-major releases #55732
base: main
Are you sure you want to change the base?
doc: enforce strict policy to semver-major releases #55732
Conversation
Review requested:
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is, it's wrong to say this PR enforces the strict policy, the commit message is a bit misleading. You could say "clarify", or maybe "stiffen".
IMO, this should either go in the collaborator-guibe.md
document (if we expect non-releasers to comply with that policy), and/or the collaborator guide should forbid non-releasers to land semver-major PRs (I don't think we want to do that). If we want the policy to be enforced, the CQ should probably be updated to skip semver-major PRs until the branch-off.
I think landing a |
No `SEMVER-MAJOR` pull requests should be landed within one month prior to | ||
the major release date, unless there is consensus from the Node.js releasers | ||
team to do so. This measure aims to ensure better stability for the release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't read it like that, so you mean like the following?
No `SEMVER-MAJOR` pull requests should be landed within one month prior to | |
the major release date, unless there is consensus from the Node.js releasers | |
team to do so. This measure aims to ensure better stability for the release | |
If a `SEMVER-MAJOR` pull requests lands on the default branch within one month prior to | |
the major release date, it must not be included on the new major staging branch, unless there is consensus from the Node.js releasers | |
team to do so. This measure aims to ensure better stability for the release |
Refs: nodejs/Release#1054
This needs to be discussed first by the @nodejs/releasers. However, since the next session (nodejs/TSC#1648) might not happen due to NodeConf/Collab Summit I thought would be better to discuss it async.
cc: @nodejs/releasers @BethGriggs