Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add LJHarb to collaborators #56132

Merged
merged 1 commit into from
Dec 4, 2024
Merged

doc: add LJHarb to collaborators #56132

merged 1 commit into from
Dec 4, 2024
+2 −0

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Dec 4, 2024

Fixes: #55918

@ljharb ljharb added the doc Issues and PRs related to the documentations. label Dec 4, 2024
@ljharb ljharb requested review from anonrig and removed request for anonrig December 4, 2024 19:15
@ljharb ljharb added notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Fast-track has been requested by @ljharb. Please 👍 to approve.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @ljharb.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@ljharb ljharb mentioned this pull request Dec 4, 2024
Closed
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 4, 2024
debadree25
debadree25 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@debadree25 debadree25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!!

@ljharb
doc: add LJHarb to collaborators
c4aa34a 
Fixes: nodejs#55918
PR-URL: nodejs#56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@ljharb ljharb merged commit c4aa34a into nodejs:main Dec 4, 2024
12 checks passed
@ljharb ljharb deleted the ljharb-collab branch December 4, 2024 19:37
@ljharb
Copy link
Member Author

ljharb commented Dec 4, 2024

Landed c4aa34a.

aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@ljharb @nodejs-github-bot
doc: add LJHarb to collaborators
49f88a0 
Fixes: nodejs#55918
PR-URL: nodejs#56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos pushed a commit that referenced this pull request Dec 6, 2024
@ljharb @targos
doc: add LJHarb to collaborators
59d6891 
Fixes: #55918
PR-URL: #56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos added a commit that referenced this pull request Dec 6, 2024
@targos
2024-12-10, Version 23.4.0 (Current)
ea235ca 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
net:
  * (SEMVER-MINOR) add BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blockList in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) support blockList in net.Server (theanarkh) #56079
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
@targos targos mentioned this pull request Dec 6, 2024
Merged
aduh95 added a commit that referenced this pull request Dec 10, 2024
@aduh95
2024-12-10, Version 23.4.0 (Current)
e8cf3a6 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
  * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
aduh95 added a commit that referenced this pull request Dec 10, 2024
@aduh95
2024-12-10, Version 23.4.0 (Current)
b932930 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890
net:
  * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076
  * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213

PR-URL: #56119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@debadree25 debadree25 debadree25 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ronag ronag ronag approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominating @ljharb to be a Collaborator
8 participants
@ljharb @ruyadorno @jasnell @anonrig @ronag @BridgeAR @debadree25 @RafaelGSS