Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix check fd #56000

Merged
merged 1 commit into from
Nov 28, 2024
Merged

src: fix check fd #56000

merged 1 commit into from
Nov 28, 2024

Conversation

theanarkh
Copy link
Contributor

Fixed: #55983

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 26, 2024
anonrig
anonrig requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use GetValidatedFd() function to get the file descriptor, and throw the error according to it:

node/src/util.cc

Line 807 in 4f62ab5

v8::Maybe<int32_t> GetValidatedFd(Environment* env,

@theanarkh
Copy link
Contributor Author

GetValidatedFd call util::DetermineSpecificErrorType to get the the error message.

aduh95
aduh95 approved these changes Nov 26, 2024
View reviewed changes
test/parallel/test-fs-stat.js Outdated Show resolved Hide resolved
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63716/

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.96%. Comparing base (7a7c2b3) to head (83ff67c).
Report is 309 commits behind head on main.

Files with missing lines Patch % Lines
src/util.cc 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56000      +/-   ##
==========================================
- Coverage   88.41%   87.96%   -0.46%     
==========================================
  Files         652      656       +4     
  Lines      186878   188317    +1439     
  Branches    36061    35976      -85     
==========================================
+ Hits       165236   165652     +416     
- Misses      14895    15838     +943     
- Partials     6747     6827      +80
Files with missing lines Coverage Δ
src/util.cc 87.16% <71.42%> (-0.24%) ⬇️

... and 230 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63717/

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63718/

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63720/

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63724/

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63737/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63739/

@LiviaMedeiros
Copy link
Contributor

@theanarkh Usually when CI fails due to flakiness, Resume build in Jenkins is preferable over full rebuild or reapplying request-ci Add this label to start a Jenkins CI on a PR. label.

@theanarkh
Copy link
Contributor Author

Thanks.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit aa7c8cc into nodejs:main Nov 28, 2024
79 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in aa7c8cc

targos pushed a commit that referenced this pull request Dec 2, 2024
@theanarkh @targos
src: fix check fd
b778a4f 
PR-URL: #56000
Fixes: #55983
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazelly jazelly jazelly approved these changes

@juanarbol juanarbol juanarbol approved these changes

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.fstat results in an abort with some arguments
7 participants
@theanarkh @nodejs-github-bot @LiviaMedeiros @anonrig @aduh95 @juanarbol @jazelly