Remove unused import from sample code #55570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `node:path` module is referenced in a code snippet that doesn't actually use it.
|
Thanks for the contribution. Could you also please remove it from the cjs example? |
|
Hi! Could amend your commit message to follow the project's guidelines? It should start with |
rluvaton
approved these changes
Nov 1, 2024
@targos the cjs path uses it |
aduh95
approved these changes
Nov 27, 2024
|
Landed in e64f949 |
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
The `node:path` module is referenced in a code snippet that doesn't actually use it. PR-URL: #55570 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
github-actions bot
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
The `node:path` module is referenced in a code snippet that doesn't actually use it. PR-URL: nodejs#55570 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
The `node:path` module is referenced in a code snippet that doesn't actually use it. PR-URL: nodejs#55570 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
The `node:path` module is referenced in a code snippet that doesn't actually use it. PR-URL: nodejs#55570 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
node:pathmodule is referenced in a code snippet that doesn't actually use it.