Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ensure cli.md is in alphabetical order #56025

Merged
merged 1 commit into from
Dec 5, 2024
Merged

test: ensure cli.md is in alphabetical order #56025

merged 1 commit into from
Dec 5, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 27, 2024

Superseding #55790

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 27, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.95%. Comparing base (9029aec) to head (5b4a6fb).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56025   +/-   ##
=======================================
  Coverage   87.95%   87.95%           
=======================================
  Files         656      656           
  Lines      188372   188372           
  Branches    35979    35977    -2     
=======================================
+ Hits       165687   165690    +3     
+ Misses      15851    15849    -2     
+ Partials     6834     6833    -1

see 20 files with indirect coverage changes

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Nov 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63729/

lpinca
lpinca approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63799/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2024
@aduh95 @RedYetiDev
test: ensure cli.md is in alphabetical order
556f1ae 
Co-authored-by: RedYetiDev <redyetidev@gmail.com>
PR-URL: nodejs#56025
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Dec 5, 2024

Landed in 556f1ae

@aduh95 aduh95 merged commit 556f1ae into nodejs:main Dec 5, 2024
19 checks passed
@aduh95 aduh95 deleted the cli-alpha-order branch December 5, 2024 13:49
targos pushed a commit that referenced this pull request Dec 6, 2024
@aduh95 @RedYetiDev @targos
test: ensure cli.md is in alphabetical order
046e642 
Co-authored-by: RedYetiDev <redyetidev@gmail.com>
PR-URL: #56025
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Dec 6, 2024
Merged
aduh95 added a commit that referenced this pull request Dec 13, 2024
@aduh95 @RedYetiDev
test: ensure cli.md is in alphabetical order
88f8257 
Co-authored-by: RedYetiDev <redyetidev@gmail.com>
PR-URL: #56025
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 added a commit that referenced this pull request Dec 13, 2024
@aduh95 @RedYetiDev
test: ensure cli.md is in alphabetical order
db32eab 
Co-authored-by: RedYetiDev <redyetidev@gmail.com>
PR-URL: #56025
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 added a commit that referenced this pull request Dec 13, 2024
@aduh95 @RedYetiDev
test: ensure cli.md is in alphabetical order
cc7c8e3 
Co-authored-by: RedYetiDev <redyetidev@gmail.com>
PR-URL: #56025
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Dec 14, 2024
Closed
aduh95 added a commit that referenced this pull request Dec 18, 2024
@aduh95 @RedYetiDev
test: ensure cli.md is in alphabetical order
c794234 
Co-authored-by: RedYetiDev <redyetidev@gmail.com>
PR-URL: #56025
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduh95 @nodejs-github-bot @lpinca