tools: update create-release-proposal workflow
#56054
Conversation
|
Review requested:
|
nodejs-github-bot
added
meta
|
Tested with https://github.com/aduh95/node/actions/runs/12096176457/job/33730174026, which created aduh95#30 |
| -f "ref=refs/heads/$HEAD_BRANCH" -f "sha=$HEAD_SHA" | ||
|
|
||
| # Create the proposal PR | ||
| PR_URL="$(gh api \ |
There was a problem hiding this comment.
Why not gh pr create as its the "official" way to create PR using gh?
There was a problem hiding this comment.
I don’t think gh is more official than the REST API. I find this way more straightforward (no need for git push --force – no need for git push even), and I don’t think there’s a simpler way to create a signed commit from gha.
There was a problem hiding this comment.
oh noes, I'm strongly -1 to this, as I don't think this is straightforward at all, the GitHub cli is super user-friendly and we already have people pushed away from contributing to this very script from the fact it's not using gh anymore: #56128 (comment)
This comment was marked as spam.
This comment was marked as spam.
aduh95
force-pushed
the
create-release-proposal
branch
from
b71ec72 to
0035942
Compare
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 60e9c6f |
PR-URL: #56054 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #56054 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #56054 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #56054 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #56054 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
We can remove the permission for the repo to
git push, and instead use acreateCommitOnBranchAPI call to create the release commit, which has the upside of being signed.I've also use this PR as an opportunity to tidy things up (e.g. we don't need a JENKINS_TOKEN, or to fetch the whole repo)