src: avoid copy on getV8FastApiCallCount #56081
Merged
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
approved these changes
Nov 29, 2024
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56081 +/- ##
==========================================
+ Coverage 87.99% 88.01% +0.01%
==========================================
Files 656 656
Lines 188988 188988
Branches 35988 35990 +2
==========================================
+ Hits 166302 166332 +30
+ Misses 15848 15827 -21
+ Partials 6838 6829 -9 |
targos
approved these changes
Nov 29, 2024
anonrig
added
the
commit-queue
juanarbol
approved these changes
Nov 30, 2024
mertcanaltin
approved these changes
Nov 30, 2024
lpinca
approved these changes
Nov 30, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in de5f91d |
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
PR-URL: #56081 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids copy by calling
ToStringView()