fs: cache ReadFileContext after lazy loading #55998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
gurgunday
changed the title
anonrig
approved these changes
Nov 26, 2024
LiviaMedeiros
approved these changes
Nov 26, 2024
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55998 +/- ##
=======================================
Coverage 87.95% 87.96%
=======================================
Files 656 656
Lines 188310 188311 +1
Branches 35963 35970 +7
=======================================
+ Hits 165630 165642 +12
+ Misses 15854 15842 -12
- Partials 6826 6827 +1
|
anonrig
added
author ready
lpinca
approved these changes
Nov 26, 2024
mertcanaltin
approved these changes
Nov 27, 2024
jazelly
approved these changes
Nov 28, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in ba912ee |
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
PR-URL: #55998 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why it's
required at every call, I think we can cache it after the lazy loadAll tests pass on my end