Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use spaceship operator in SocketAddress #56059

Closed
wants to merge 1 commit into from
Closed

src: use spaceship operator in SocketAddress #56059

wants to merge 1 commit into from
+49 −76

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 28, 2024 •
edited
Loading

Just some minor cleanups. There's a lot more than can be cleaned up / improved in this class but just starting small and incremental

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63751/

tniessen
tniessen approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🚀

@anonrig anonrig mentioned this pull request Nov 28, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.95%. Comparing base (d09458f) to head (35c28f0).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sockaddr.cc 81.48% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56059      +/-   ##
==========================================
- Coverage   87.96%   87.95%   -0.01%     
==========================================
  Files         656      656              
  Lines      188384   188387       +3     
  Branches    35968    35979      +11     
==========================================
- Hits       165707   165698       -9     
- Misses      15845    15846       +1     
- Partials     6832     6843      +11
Files with missing lines Coverage Δ
src/node_sockaddr-inl.h 80.76% <100.00%> (-1.12%) ⬇️
src/node_sockaddr.h 38.23% <ø> (ø)
src/node_sockaddr.cc 72.17% <81.48%> (+0.20%) ⬆️

... and 23 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63778/

jasnell added a commit that referenced this pull request Dec 3, 2024
@jasnell
src: use spaceship operator in SocketAddress
b915124 
PR-URL: #56059
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@jasnell
Copy link
Member Author

jasnell commented Dec 3, 2024

Landed in b915124

@jasnell jasnell closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @anonrig @tniessen