src: modernize cleanup queue to use c++20

[anonrig]

Getting the idea from @jasnell on #56059, let's use std::ranges::sort and spaceship operator to sort with std::ranges::sort which is available on C++20.

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (4cf6fab) to head (2a94e99).
Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
src/cleanup_queue-inl.h	71.42%	1 Missing and 1 partial ⚠️
src/cleanup_queue.cc	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56063      +/-   ##
==========================================
- Coverage   88.00%   87.99%   -0.01%     
==========================================
  Files         656      656              
  Lines      188988   189002      +14     
  Branches    35992    35988       -4     
==========================================
- Hits       166315   166310       -5     
- Misses      15838    15849      +11     
- Partials     6835     6843       +8     

Files with missing lines	Coverage Δ
src/cleanup_queue.h	100.00% <ø> (ø)
src/cleanup_queue.cc	81.25% <75.00%> (-4.47%)	⬇️
src/cleanup_queue-inl.h	85.00% <71.42%> (-7.31%)	⬇️

... and 27 files with indirect coverage changes

[legendecas]

LGTM, thanks! Commented some style thoughts...

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63785/

[anonrig]

cc @nodejs/build is there a limitation in macOS regarding this?

12:42:22 ../src/cleanup_queue-inl.h:35:17: error: no member named 'strong_ordering' in namespace 'std'
12:42:22     return std::strong_ordering::greater;
12:42:22            ~~~~~^
12:42:22 ../src/cleanup_queue-inl.h:39:17: error: no member named 'strong_ordering' in namespace 'std'
12:42:22     return std::strong_ordering::less;
12:42:22            ~~~~~^
12:42:22 ../src/cleanup_queue-inl.h:41:15: error: no member named 'strong_ordering' in namespace 'std'
12:42:22   return std::strong_ordering::equivalent;
12:42:22          ~~~~~^

[jasnell]

Are you missing an #include <compare>

[anonrig]

Are you missing an #include <compare>

Yes, but is it only required on macOS?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63793/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63801/

[anonrig]

cc @nodejs/build This is blocked my macOS infrastructure as well.

20:44:45 ../src/cleanup_queue.cc:3:10: fatal error: 'ranges' file not found
20:44:45 #include <ranges>
20:44:45          ^~~~~~~~
20:44:46 1 error generated.