Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: rename file to advocacy-ambassador-program.md #56046

Merged
merged 1 commit into from
Nov 30, 2024
Merged

doc: rename file to advocacy-ambassador-program.md #56046

merged 1 commit into from
Nov 30, 2024

Conversation

tniessen
Copy link
Member

ambasador → ambassador

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 28, 2024
@richardlau
Copy link
Member

When this lands the link in https://github.com/nodejs/nodejs-ambassadors/blob/1ced978c8b2396e26e67fb8a5e323a411bc8d686/README.md?plain=1#L7 will need to be updated.

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit 3fb2ea8 into nodejs:main Nov 30, 2024
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3fb2ea8

targos pushed a commit that referenced this pull request Dec 2, 2024
@tniessen @targos
doc: rename file to advocacy-ambassador-program.md
3b4ef93 
PR-URL: #56046
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
mhdawson
mhdawson reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson left review comments

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @richardlau @lpinca @mhdawson @RafaelGSS @marco-ippolito