Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove test-fs-utimes flaky designation #56052

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 28, 2024

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 28, 2024
@lpinca lpinca force-pushed the remove/flaky-test-fs-utimes branch from 51e89c2 to c287196 Compare November 28, 2024 10:25
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (3f9c6c0) to head (abee765).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56052      +/-   ##
==========================================
- Coverage   87.99%   87.99%   -0.01%     
==========================================
  Files         656      656              
  Lines      189000   189000              
  Branches    35992    35989       -3     
==========================================
- Hits       166308   166304       -4     
- Misses      15851    15853       +2     
- Partials     6841     6843       +2     

see 22 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

The issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54844
Refs: nodejs#54802
@lpinca lpinca force-pushed the remove/flaky-test-fs-utimes branch from c287196 to abee765 Compare December 1, 2024 13:22
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7904bc0 into nodejs:main Dec 6, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7904bc0

@lpinca lpinca deleted the remove/flaky-test-fs-utimes branch December 6, 2024 06:42
targos pushed a commit that referenced this pull request Dec 6, 2024
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Dec 18, 2024
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants