-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove test-fs-utimes flaky designation #56052
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
lpinca:remove/flaky-test-fs-utimes
Dec 6, 2024
Merged
test: remove test-fs-utimes flaky designation #56052
nodejs-github-bot
merged 1 commit into
nodejs:main
from
lpinca:remove/flaky-test-fs-utimes
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Nov 28, 2024
lpinca
force-pushed
the
remove/flaky-test-fs-utimes
branch
from
November 28, 2024 10:25
51e89c2
to
c287196
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56052 +/- ##
==========================================
- Coverage 87.99% 87.99% -0.01%
==========================================
Files 656 656
Lines 189000 189000
Branches 35992 35989 -3
==========================================
- Hits 166308 166304 -4
- Misses 15851 15853 +2
- Partials 6841 6843 +2 |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 28, 2024
The issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54844 Refs: nodejs#54802
lpinca
force-pushed
the
remove/flaky-test-fs-utimes
branch
from
December 1, 2024 13:22
c287196
to
abee765
Compare
targos
approved these changes
Dec 1, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 5, 2024
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 6, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 6, 2024
Landed in 7904bc0 |
targos
pushed a commit
that referenced
this pull request
Dec 6, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is likely the same as other tests that time out.
Refs: #54918
Refs: #54844
Refs: #54802