lib: add validation for options in compileFunction #56023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56023 +/- ##
==========================================
+ Coverage 87.95% 87.99% +0.03%
==========================================
Files 656 656
Lines 188372 188960 +588
Branches 35979 35975 -4
==========================================
+ Hits 165687 166275 +588
- Misses 15851 15854 +3
+ Partials 6834 6831 -3
|
legendecas
reviewed
Dec 3, 2024
kimtaejin3
force-pushed
the
enhancement/compileFunction-options-validation
branch
2 times, most recently
from
4cdcf53 to
bda151e
Compare
kimtaejin3
force-pushed
the
enhancement/compileFunction-options-validation
branch
from
bda151e to
8df7b68
Compare
|
@legendecas I added a test case, can you please check it? |
legendecas
approved these changes
Dec 4, 2024
legendecas
added
author ready
github-actions
bot
removed
the
request-ci
juanarbol
approved these changes
Dec 5, 2024
github-actions
bot
removed
the
request-ci
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 56c8360 |
targos
pushed a commit
that referenced
this pull request
Dec 6, 2024
PR-URL: #56023 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #56023 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #56023 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #56023 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
PR-URL: #56023 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a validation step for the options parameter in the compileFunction method within lib/vm.js.
The validateObject function is used to ensure that options is an object, aligning with the validation approach used in other functions like measureMemory in lib/vm.js.