test: move test-worker-arraybuffer-zerofill to parallel #56053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56053 +/- ##
==========================================
- Coverage 87.97% 87.96% -0.01%
==========================================
Files 656 656
Lines 188383 188384 +1
Branches 35973 35967 -6
==========================================
- Hits 165732 165717 -15
- Misses 15821 15829 +8
- Partials 6830 6838 +8 |
github-actions
bot
removed
the
request-ci
|
The commit doesn't seem to move the file from |
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to `test/parallel/test-worker-arraybuffer-zerofill.js` and remove the flaky designation. The original issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54839 Refs: nodejs#54802
lpinca
force-pushed
the
remove/flaky-test-worker-arraybuffer-zerofill
branch
from
c392ac0 to
2e6cf79
Compare
richardlau
approved these changes
Nov 28, 2024
LiviaMedeiros
approved these changes
Nov 28, 2024
github-actions
bot
removed
the
request-ci
jakecastelli
approved these changes
Nov 29, 2024
|
shall we give it a stress test? |
lpinca
added
the
commit-queue
The stress test is sequential, so it is not very useful. It is easy to revert if needed. |
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3f9c6c0 |
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to `test/parallel/test-worker-arraybuffer-zerofill.js` and remove the flaky designation. The original issue is likely the same as other tests that time out. Refs: #54918 Refs: #54839 Refs: #54802 PR-URL: #56053 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to `test/parallel/test-worker-arraybuffer-zerofill.js` and remove the flaky designation. The original issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54839 Refs: nodejs#54802 PR-URL: nodejs#56053 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to `test/parallel/test-worker-arraybuffer-zerofill.js` and remove the flaky designation. The original issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54839 Refs: nodejs#54802 PR-URL: nodejs#56053 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to `test/parallel/test-worker-arraybuffer-zerofill.js` and remove the flaky designation. The original issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54839 Refs: nodejs#54802 PR-URL: nodejs#56053 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to `test/parallel/test-worker-arraybuffer-zerofill.js` and remove the flaky designation. The original issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54839 Refs: nodejs#54802 PR-URL: nodejs#56053 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
test/sequential/test-worker-arraybuffer-zerofill.jsback totest/parallel/test-worker-arraybuffer-zerofill.jsand remove the flaky designation.The original issue is likely the same as other tests that time out.
Refs: #54918
Refs: #54839
Refs: #54802