-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src,build: add no user defined deduction guides of CTAD check #56071
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
labels
Nov 29, 2024
Loading status checks…
legendecas
force-pushed
the
build/ctad
branch
from
November 29, 2024 11:54
6209418
to
8d59040
Compare
legendecas
changed the title
build: add no user defined deduction guides of CTAD check
src,build: add no user defined deduction guides of CTAD check
Nov 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56071 +/- ##
==========================================
+ Coverage 87.96% 88.01% +0.04%
==========================================
Files 656 656
Lines 188384 188988 +604
Branches 35968 35989 +21
==========================================
+ Hits 165707 166331 +624
- Misses 15845 15846 +1
+ Partials 6832 6811 -21
|
anonrig
approved these changes
Nov 29, 2024
anonrig
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Nov 29, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 29, 2024
jasnell
approved these changes
Nov 29, 2024
legendecas
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 6, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 6, 2024
Landed in 4211ab5 |
legendecas
added
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
and removed
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
labels
Dec 6, 2024
targos
pushed a commit
that referenced
this pull request
Dec 6, 2024
PR-URL: #56071 Refs: https://google.github.io/styleguide/cppguide.html#CTAD Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
Loading
Loading status checks…
PR-URL: #56071 Refs: https://google.github.io/styleguide/cppguide.html#CTAD Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
Loading
Loading status checks…
PR-URL: #56071 Refs: https://google.github.io/styleguide/cppguide.html#CTAD Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
Loading
Loading status checks…
PR-URL: #56071 Refs: https://google.github.io/styleguide/cppguide.html#CTAD Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
PR-URL: #56071 Refs: https://google.github.io/styleguide/cppguide.html#CTAD Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To our secondary C++ style guide:
To use CTAD with a template, it must be defined with at least one deduction guide (
std
templates are defined with guides). Enforcing this rule with compiler checks.