Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add cli option to preserve env vars on dr #55697

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RafaelGSS
Copy link
Member

This PR introduces a new cli flag --report-preserve-env to avoid writing env vars on diagnostic reports.

Some context: https://x.com/arthurfiorette/status/1848372069198614664

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 2, 2024
lib/internal/process/report.js Outdated Show resolved Hide resolved
src/node_report_module.cc Outdated Show resolved Hide resolved
@RafaelGSS RafaelGSS added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 2, 2024
@richardlau
Copy link
Member

For consistency with --report-exclude-network I'd prefer if this was --report-exclude-env.

@RedYetiDev RedYetiDev added the report Issues and PRs related to process.report. label Nov 3, 2024
@RafaelGSS
Copy link
Member Author

PTAL @richardlau @anonrig

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (5ce3d10) to head (d4460ea).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55697      +/-   ##
==========================================
- Coverage   88.44%   88.41%   -0.03%     
==========================================
  Files         654      654              
  Lines      187720   187707      -13     
  Branches    36143    36119      -24     
==========================================
- Hits       166022   165966      -56     
- Misses      14941    14983      +42     
- Partials     6757     6758       +1     
Files with missing lines Coverage Δ
lib/internal/process/report.js 100.00% <100.00%> (ø)
src/env-inl.h 97.06% <100.00%> (+0.22%) ⬆️
src/env.h 98.14% <ø> (ø)
src/node_options.cc 87.46% <100.00%> (+0.01%) ⬆️
src/node_options.h 98.27% <100.00%> (+<0.01%) ⬆️
src/node_report.cc 93.52% <100.00%> (+0.36%) ⬆️
src/node_report_module.cc 92.57% <100.00%> (+0.35%) ⬆️

... and 45 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants