net: support blocklist for net.Server #56079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
theanarkh
force-pushed
the
support_blocklist_in_net_server
branch
from
0720545
to
4ecdf03
Compare
lpinca
reviewed
Nov 29, 2024
lpinca
added
the
semver-minor
jasnell
approved these changes
Nov 29, 2024
theanarkh
force-pushed
the
support_blocklist_in_net_server
branch
from
4ecdf03
to
83871b6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56079 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 656 656
Lines 188988 189015 +27
Branches 35992 35991 -1
=======================================
+ Hits 166315 166341 +26
- Misses 15838 15848 +10
+ Partials 6835 6826 -9
|
lpinca
reviewed
Nov 29, 2024
theanarkh
force-pushed
the
support_blocklist_in_net_server
branch
3 times, most recently
from
a1321f0
to
1bb4c67
Compare
github-actions
bot
removed
the
request-ci
|
If #56075 lands with |
theanarkh
force-pushed
the
support_blocklist_in_net_server
branch
from
1bb4c67
to
083967d
Compare
|
Done ! |
github-actions
bot
removed
the
request-ci
theanarkh
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in d5d1e80 |
targos
pushed a commit
that referenced
this pull request
Dec 3, 2024
PR-URL: #56079 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: TODO
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119
targos
pushed a commit
that referenced
this pull request
Dec 3, 2024
Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
blocklistoptions fornet.Server, which can be used for disabling inbound access to specific IP addresses, IP ranges, or IP subnets.make -j4 test(UNIX), orvcbuild test(Windows) passes