src: remove dead code in async_wrap #56065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The silent option for AsyncWrap and AsyncReset is not used anywhere. Seems like a leftover from times PromiseWrap was used.
nodejs-github-bot
added
c++
Flarna
added
async_hooks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56065 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 656 656
Lines 188988 188981 -7
Branches 35992 35990 -2
=======================================
+ Hits 166315 166316 +1
+ Misses 15838 15828 -10
- Partials 6835 6837 +2
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I've triggered a CI run |
legendecas
approved these changes
Nov 29, 2024
addaleax
approved these changes
Nov 30, 2024
Flarna
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 384fa62 |
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
The silent option for AsyncWrap and AsyncReset is not used anywhere. Seems like a leftover from times PromiseWrap was used. PR-URL: #56065 Refs: #39135 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The silent option for AsyncWrap and AsyncReset is not used anywhere.
Seems like a leftover from times PromiseWrap was used.
Refs: #39135