Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix nghttp3 updater script #56007

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 26, 2024

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 26, 2024
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 26, 2024

Tested with aduh95#15

@richardlau richardlau added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 27, 2024
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2024
tools/dep_updaters/update-nghttp3.sh Outdated Show resolved Hide resolved
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0a9524b into nodejs:main Nov 28, 2024
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0a9524b

targos pushed a commit that referenced this pull request Dec 2, 2024
PR-URL: #56007
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
github-actions bot pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56007
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56007
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56007
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56007
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56007
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants